[rhythmbox] player: protect against taglists giving us NULL tags (bug #625375)



commit 69ff95f027a3f31e2cef9dc63aca2b8c51d0f59d
Author: Jonathan Matthew <jonathan d14n org>
Date:   Tue Jul 27 20:44:37 2010 +1000

    player: protect against taglists giving us NULL tags (bug #625375)

 backends/gstreamer/rb-player-gst-xfade.c |    2 +-
 backends/gstreamer/rb-player-gst.c       |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/backends/gstreamer/rb-player-gst-xfade.c b/backends/gstreamer/rb-player-gst-xfade.c
index 0eb0fc3..1f677ea 100644
--- a/backends/gstreamer/rb-player-gst-xfade.c
+++ b/backends/gstreamer/rb-player-gst-xfade.c
@@ -1505,7 +1505,7 @@ process_tag (const GstTagList *list, const gchar *tag, RBXFadeStream *stream)
 	GValue value = {0,};
 
 	/* process embedded images */
-	if (!strcmp (tag, GST_TAG_IMAGE) || !strcmp (tag, GST_TAG_PREVIEW_IMAGE)) {
+	if (!g_strcmp0 (tag, GST_TAG_IMAGE) || !g_strcmp0 (tag, GST_TAG_PREVIEW_IMAGE)) {
 		GdkPixbuf *pixbuf;
 		pixbuf = rb_gst_process_embedded_image (list, tag);
 		if (pixbuf != NULL) {
diff --git a/backends/gstreamer/rb-player-gst.c b/backends/gstreamer/rb-player-gst.c
index d25eddc..636da50 100644
--- a/backends/gstreamer/rb-player-gst.c
+++ b/backends/gstreamer/rb-player-gst.c
@@ -213,7 +213,7 @@ process_tag (const GstTagList *list, const gchar *tag, RBPlayerGst *player)
 	GValue value = {0,};
 
 	/* process embedded images */
-	if (!strcmp (tag, GST_TAG_IMAGE) || !strcmp (tag, GST_TAG_PREVIEW_IMAGE)) {
+	if (!g_strcmp0 (tag, GST_TAG_IMAGE) || !g_strcmp0 (tag, GST_TAG_PREVIEW_IMAGE)) {
 		GdkPixbuf *pixbuf;
 		pixbuf = rb_gst_process_embedded_image (list, tag);
 		if (pixbuf != NULL) {



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]