[empathy] Use explicit boolean expressions for if-conditionals, according to Telepathy style.
- From: Travis Reitter <treitter src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [empathy] Use explicit boolean expressions for if-conditionals, according to Telepathy style.
- Date: Tue, 20 Jul 2010 23:23:27 +0000 (UTC)
commit 7473d7a97d02be9aeefa271269184485ddf460a4
Author: Travis Reitter <treitter gmail com>
Date: Wed Jul 7 19:22:15 2010 -0700
Use explicit boolean expressions for if-conditionals, according to Telepathy style.
libempathy-gtk/empathy-contact-widget.c | 12 ++++++------
libempathy-gtk/empathy-individual-store.c | 2 +-
libempathy-gtk/empathy-individual-view.c | 6 +++---
src/empathy-main-window.c | 6 +++---
4 files changed, 13 insertions(+), 13 deletions(-)
---
diff --git a/libempathy-gtk/empathy-contact-widget.c b/libempathy-gtk/empathy-contact-widget.c
index 851aa53..99dd077 100644
--- a/libempathy-gtk/empathy-contact-widget.c
+++ b/libempathy-gtk/empathy-contact-widget.c
@@ -577,12 +577,12 @@ contact_widget_cell_toggled (GtkCellRendererToggle *cell,
gtk_list_store_set (store, &iter, COL_ENABLED, !enabled, -1);
gtk_tree_path_free (path);
- if (group)
+ if (group != NULL)
{
FolksIndividual *individual = folks_individual_from_empathy_contact (
information->contact);
- if (individual)
+ if (individual != NULL)
{
folks_groups_change_group (FOLKS_GROUPS (individual), group, !enabled);
g_object_unref (individual);
@@ -810,7 +810,7 @@ contact_widget_button_group_clicked_cb (GtkButton *button,
individual = folks_individual_from_empathy_contact (information->contact);
- if (individual)
+ if (individual != NULL)
{
folks_groups_change_group (FOLKS_GROUPS (individual), group, TRUE);
g_object_unref (individual);
@@ -1339,7 +1339,7 @@ contact_widget_entry_alias_focus_event_cb (GtkEditable *editable,
FolksIndividual *individual = folks_individual_from_empathy_contact (
information->contact);
- if (individual)
+ if (individual != NULL)
{
folks_alias_set_alias (FOLKS_ALIAS (individual), alias);
g_object_unref (individual);
@@ -1537,7 +1537,7 @@ contact_widget_contact_update (EmpathyContactWidget *information)
FolksIndividual *individual = folks_individual_from_empathy_contact (
information->contact);
- if (individual)
+ if (individual != NULL)
{
gboolean is_favourite = folks_favourite_get_is_favourite (
FOLKS_FAVOURITE (individual));
@@ -1674,7 +1674,7 @@ favourite_toggled_cb (GtkToggleButton *button,
FolksIndividual *individual = folks_individual_from_empathy_contact (
information->contact);
- if (individual)
+ if (individual != NULL)
{
gboolean active = gtk_toggle_button_get_active (button);
folks_favourite_set_is_favourite (FOLKS_FAVOURITE (individual), active);
diff --git a/libempathy-gtk/empathy-individual-store.c b/libempathy-gtk/empathy-individual-store.c
index b47b310..87fa800 100644
--- a/libempathy-gtk/empathy-individual-store.c
+++ b/libempathy-gtk/empathy-individual-store.c
@@ -269,7 +269,7 @@ individual_store_find_contact_foreach (GtkTreeModel *model,
fc->iters = g_list_append (fc->iters, gtk_tree_iter_copy (iter));
}
- if (individual)
+ if (individual != NULL)
{
g_object_unref (individual);
}
diff --git a/libempathy-gtk/empathy-individual-view.c b/libempathy-gtk/empathy-individual-view.c
index 43d4a78..dc90990 100644
--- a/libempathy-gtk/empathy-individual-view.c
+++ b/libempathy-gtk/empathy-individual-view.c
@@ -899,7 +899,7 @@ individual_view_row_activated (GtkTreeView *view,
contact = empathy_contact_from_folks_individual (individual);
- if (contact)
+ if (contact != NULL)
{
DEBUG ("Starting a chat");
@@ -1985,7 +1985,7 @@ individual_view_group_remove_activate_cb (GtkMenuItem *menuitem,
gchar *group;
group = empathy_individual_view_get_selected_group (view, NULL);
- if (group)
+ if (group != NULL)
{
gchar *text;
GtkWindow *parent;
@@ -2073,7 +2073,7 @@ individual_view_remove_activate_cb (GtkMenuItem *menuitem,
individual = empathy_individual_view_dup_selected (view);
- if (individual)
+ if (individual != NULL)
{
gchar *text;
GtkWindow *parent;
diff --git a/src/empathy-main-window.c b/src/empathy-main-window.c
index f6fe0c9..58ace96 100644
--- a/src/empathy-main-window.c
+++ b/src/empathy-main-window.c
@@ -189,7 +189,7 @@ main_window_flash_foreach (GtkTreeModel *model,
contact = empathy_contact_from_folks_individual (individual);
if (contact != data->event->contact) {
- if (contact) {
+ if (contact != NULL) {
g_object_unref (contact);
}
return FALSE;
@@ -221,7 +221,7 @@ main_window_flash_foreach (GtkTreeModel *model,
}
g_object_unref (individual);
- if (contact)
+ if (contact != NULL)
g_object_unref (contact);
return FALSE;
@@ -355,7 +355,7 @@ main_window_row_activated_cb (EmpathyContactListView *view,
g_object_unref (contact);
OUT:
- if (individual)
+ if (individual != NULL)
g_object_unref (individual);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]