[gnumeric] function tooltip: fix the check for unclosed strings.



commit 320f5fef6ee81d8d6d16a23e2811ce692b160513
Author: Andreas J Guelzow <aguelzow pyrshep ca>
Date:   Mon Jul 19 08:36:14 2010 -0600

    function tooltip:  fix the check for unclosed strings.
    
    2010-07-19  Andreas J. Guelzow <aguelzow pyrshep ca>
    
    	* gnumeric-expr-entry.c (gee_check_tooltip): fix the check for unclosed
    	  strings.

 BUGS                              |    8 +++-----
 src/widgets/ChangeLog             |    5 +++++
 src/widgets/gnumeric-expr-entry.c |    2 +-
 3 files changed, 9 insertions(+), 6 deletions(-)
---
diff --git a/BUGS b/BUGS
index 918a4fb..608d3f4 100644
--- a/BUGS
+++ b/BUGS
@@ -55,7 +55,6 @@ Misc stuff that should be fixed
 - Missing undo/redo for
     - Freeze panes (tricky this is a view attribute)
     - `Add Scenario' Portion of Solver
-    - Workbook attr changes
  
 - cols/rows
     : Make unhide smarter to find hidden regions on either side of
@@ -128,16 +127,15 @@ Architecture Changes
 
 2) Font handling (move to GOFont)
 
-3) Function docs
-    4.1) Use multiple tagged paragraphs (DONE)
+3) Function docs                                                (DONE)
 
 4) AutoFilter [share functionality with slicers]
     4.19) Change value entries in expr dialog into combos
     4.4) 2nd value in expr dialog only if 1st is active
-    4.23) undo/redo for creation
+    4.23) undo/redo for creation                                (DONE)
     4.24) undo/redo for condition set change
     4.25) Undo redo support for ins/del col/row with filters
-    4.26) guess initial region if its a singleton
+    4.26) guess initial region if its a singleton               (DONE)
     4.27) combo contains start to end of continuous region
            not just the end of the selected region
     4.28) filter changes should dirty things
diff --git a/src/widgets/ChangeLog b/src/widgets/ChangeLog
index ae2332e..449992f 100644
--- a/src/widgets/ChangeLog
+++ b/src/widgets/ChangeLog
@@ -1,3 +1,8 @@
+2010-07-19  Andreas J. Guelzow <aguelzow pyrshep ca>
+
+	* gnumeric-expr-entry.c (gee_check_tooltip): fix the check for unclosed
+	  strings.
+	
 2010-07-18  Morten Welinder  <terra gnome org>
 
 	* gnumeric-expr-entry.c (cb_icon_clicked): Fix signedness problem.
diff --git a/src/widgets/gnumeric-expr-entry.c b/src/widgets/gnumeric-expr-entry.c
index bfe143c..7429bbf 100644
--- a/src/widgets/gnumeric-expr-entry.c
+++ b/src/widgets/gnumeric-expr-entry.c
@@ -801,9 +801,9 @@ gee_check_tooltip (GnmExprEntry *gee)
 			continue;
 		if (gli->start == 0)
 			goto not_found;
-		end = gli->start - 1;
 		gli->token = 0;
 		stuff = TRUE;
+		break;
 	}
 	gli--;
 



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]