[evolution/gnome-2-30] Bug #624335 - Abort after group-by-thread with certain sorting



commit 1dc0de3a0306c2fcf05b8070fe5efcf1e16c3b5f
Author: Milan Crha <mcrha redhat com>
Date:   Wed Jul 14 15:30:56 2010 +0200

    Bug #624335 - Abort after group-by-thread with certain sorting

 mail/message-list.c |   17 ++---------------
 1 files changed, 2 insertions(+), 15 deletions(-)
---
diff --git a/mail/message-list.c b/mail/message-list.c
index ddbf243..f25dc12 100644
--- a/mail/message-list.c
+++ b/mail/message-list.c
@@ -4413,21 +4413,8 @@ static void
 free_message_info_data (gpointer uid, struct sort_message_info_data *data, struct sort_array_data *sort_data)
 {
 	if (data->values) {
-		gint i;
-
-		g_return_if_fail (data->values->len <= sort_data->sort_columns->len);
-
-		for (i = 0; i < data->values->len; i++) {
-			gpointer v = g_ptr_array_index (data->values, i);
-			struct sort_column_data *scol;
-
-			if (!v)
-				continue;
-
-			scol = g_ptr_array_index (sort_data->sort_columns, i);
-			ml_free_value (NULL, scol->col->compare_col, v, NULL);
-		}
-
+		/* values in this array are not newly allocated, even ml_tree_value_at_ex
+		   returns gpointer, not a gconstpointer */
 		g_ptr_array_free (data->values, TRUE);
 	}
 



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]