[banshee/stable-1.6] [StreamTagger] Correct importing of compilation albums
- From: Gabriel Burt <gburt src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [banshee/stable-1.6] [StreamTagger] Correct importing of compilation albums
- Date: Fri, 9 Jul 2010 20:22:42 +0000 (UTC)
commit d07576cccb58d04e0807ba2557360bc9664eba33
Author: Alex Mauer <hawke hawkesnest net>
Date: Wed Jun 23 20:34:28 2010 -0500
[StreamTagger] Correct importing of compilation albums
Fix an order of operations bug where for tracks on a compilation album
where the track artist equals the album artist, the track wasn't being
recognized as on a compilation album.
https://bugzilla.gnome.org/show_bug.cgi?id=602840
Signed-off-by: Gabriel Burt <gabriel burt gmail com>
.../Banshee.Core/Banshee.Streaming/StreamTagger.cs | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
---
diff --git a/src/Core/Banshee.Core/Banshee.Streaming/StreamTagger.cs b/src/Core/Banshee.Core/Banshee.Streaming/StreamTagger.cs
index b8ac65a..b0d90b8 100644
--- a/src/Core/Banshee.Core/Banshee.Streaming/StreamTagger.cs
+++ b/src/Core/Banshee.Core/Banshee.Streaming/StreamTagger.cs
@@ -164,9 +164,10 @@ namespace Banshee.Streaming
track.ArtistNameSort = Choose (file.Tag.JoinedPerformersSort, track.ArtistNameSort, preferTrackInfo);
track.AlbumTitle = Choose (file.Tag.Album, track.AlbumTitle, preferTrackInfo);
track.AlbumTitleSort = Choose (file.Tag.AlbumSort, track.AlbumTitleSort, preferTrackInfo);
+ // AlbumArtist cannot be set until the track is marked as a compilation.
+ track.IsCompilation = preferTrackInfo ? track.IsCompilation : IsCompilation (file);
track.AlbumArtist = Choose (file.Tag.FirstAlbumArtist, track.AlbumArtist, preferTrackInfo);
track.AlbumArtistSort = Choose (file.Tag.FirstAlbumArtistSort, track.AlbumArtistSort, preferTrackInfo);
- track.IsCompilation = preferTrackInfo ? track.IsCompilation : IsCompilation (file);
track.TrackTitle = Choose (file.Tag.Title, track.TrackTitle, preferTrackInfo);
track.TrackTitleSort = Choose (file.Tag.TitleSort, track.TrackTitleSort, preferTrackInfo);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]