[empathy] chat: add FIXME explaining how we should ideally request channels
- From: Guillaume Desmottes <gdesmott src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [empathy] chat: add FIXME explaining how we should ideally request channels
- Date: Wed, 7 Jul 2010 08:03:26 +0000 (UTC)
commit ac6f56a439647386c15fdd6045c00b914f4975f9
Author: Guillaume Desmottes <guillaume desmottes collabora co uk>
Date: Tue Jul 6 16:29:29 2010 +0200
chat: add FIXME explaining how we should ideally request channels
libempathy-gtk/empathy-chat.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
---
diff --git a/libempathy-gtk/empathy-chat.c b/libempathy-gtk/empathy-chat.c
index 9c5fcc5..17a742c 100644
--- a/libempathy-gtk/empathy-chat.c
+++ b/libempathy-gtk/empathy-chat.c
@@ -242,6 +242,9 @@ reconnected_connection_ready_cb (TpConnection *connection,
DEBUG ("Account reconnected, request a new Text channel");
+ /* FIXME: Ideally we should ask to handle ourself the channel so we can
+ * report the error if any but this is blocked by
+ * https://bugs.freedesktop.org/show_bug.cgi?id=13422 */
switch (priv->handle_type) {
case TP_HANDLE_TYPE_CONTACT:
empathy_dispatcher_chat_with_contact_id (
@@ -702,6 +705,9 @@ chat_command_join (EmpathyChat *chat,
GStrv rooms = g_strsplit_set (strv[1], ", ", -1);
+ /* FIXME: Ideally we should ask to handle ourself the channel so we can
+ * report the error if any but this is blocked by
+ * https://bugs.freedesktop.org/show_bug.cgi?id=13422 */
while (rooms[i] != NULL) {
/* ignore empty strings */
if (!EMP_STR_EMPTY (rooms[i])) {
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]