[gtksourceview] Small refactoring
- From: Paolo Borelli <pborelli src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gtksourceview] Small refactoring
- Date: Sat, 3 Jul 2010 12:20:27 +0000 (UTC)
commit ea01cde5836ba77921ac38a0f97992247732cd1e
Author: Paolo Borelli <pborelli gnome org>
Date: Sat Jul 3 14:17:37 2010 +0200
Small refactoring
gtksourceview/gtksourcecontextengine.c | 27 ++++++++++++++-------------
1 files changed, 14 insertions(+), 13 deletions(-)
---
diff --git a/gtksourceview/gtksourcecontextengine.c b/gtksourceview/gtksourcecontextengine.c
index 448975e..7ca8932 100644
--- a/gtksourceview/gtksourcecontextengine.c
+++ b/gtksourceview/gtksourcecontextengine.c
@@ -1238,7 +1238,7 @@ refresh_context_classes (GtkSourceContextEngine *ce,
#endif
}
-/**
+/*
* refresh_range:
*
* @ce: a #GtkSourceContextEngine.
@@ -1247,35 +1247,29 @@ refresh_context_classes (GtkSourceContextEngine *ce,
* @modify_refresh_region: whether updated area should be added to
* refresh_region.
*
- * Marks the area as updated - notifies view about it, and adds it to
- * refresh_region if @modify_refresh_region is %TRUE (update_syntax may
- * process huge area though actually updated is couple of lines, so in
- * that case update_syntax() takes care of refresh_region, and this
- * function only notifies the view).
+ * Marks the area as updated and notifies view about it.
*/
static void
refresh_range (GtkSourceContextEngine *ce,
const GtkTextIter *start,
- const GtkTextIter *end,
- gboolean modify_refresh_region)
+ const GtkTextIter *end)
{
GtkTextIter real_end;
if (gtk_text_iter_equal (start, end))
return;
- if (modify_refresh_region)
- gtk_text_region_add (ce->priv->refresh_region, start, end);
-
/* Refresh the contex classes here */
refresh_context_classes (ce, start, end);
/* Here we need to make sure we do not make it redraw next line */
real_end = *end;
if (gtk_text_iter_starts_line (&real_end))
+ {
/* I don't quite like this here, but at least it won't jump into
* the middle of \r\n */
gtk_text_iter_backward_cursor_position (&real_end);
+ }
g_signal_emit_by_name (ce->priv->buffer,
"highlight_updated",
@@ -2349,9 +2343,15 @@ enable_highlight (GtkSourceContextEngine *ce,
&start, &end);
if (enable)
- refresh_range (ce, &start, &end, TRUE);
+ {
+ gtk_text_region_add (ce->priv->refresh_region, start, end);
+
+ refresh_range (ce, &start, &end);
+ }
else
+ {
unhighlight_region (ce, &start, &end);
+ }
}
static void
@@ -6027,7 +6027,8 @@ update_syntax (GtkSourceContextEngine *ce,
install_idle_worker (ce);
gtk_text_iter_set_offset (&end_iter, analyzed_end);
- refresh_range (ce, &start_iter, &end_iter, FALSE);
+
+ refresh_range (ce, &start_iter, &end_iter);
PROFILE (g_print ("analyzed %d chars from %d to %d in %fms\n",
analyzed_end - start_offset, start_offset, analyzed_end,
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]