[tracker] Fixes NB#177447: Remove the 'error' signal from TrackerMiner object



commit b8eb9dbc603196656e7311e59d9341ebb6d6bae6
Author: Aleksander Morgado <aleksander lanedo com>
Date:   Thu Jul 1 15:53:19 2010 +0200

    Fixes NB#177447: Remove the 'error' signal from TrackerMiner object
    
     * The 'error' signal in TrackerMiner object was setup to return a gpointer
       via dbus, which glib-dbus didn't like, and thus it was dumping a critical
       message: g_string_append: assertion `val != NULL' failed
    
     * That 'error' signal was actually nowhere used...

 data/dbus/tracker-miner.xml                 |    4 ----
 src/libtracker-miner/tracker-miner-object.c |   18 ------------------
 src/libtracker-miner/tracker-miner-object.h |    3 ---
 3 files changed, 0 insertions(+), 25 deletions(-)
---
diff --git a/data/dbus/tracker-miner.xml b/data/dbus/tracker-miner.xml
index 2882d20..a6b521a 100644
--- a/data/dbus/tracker-miner.xml
+++ b/data/dbus/tracker-miner.xml
@@ -43,9 +43,5 @@
       <arg type="s" name="status" />
       <arg type="d" name="progress" />
     </signal>
-    <signal name="Error">
-      <arg type="i" name="code"/>
-      <arg type="s" name="reason"/>
-    </signal>
   </interface>
 </node>
diff --git a/src/libtracker-miner/tracker-miner-object.c b/src/libtracker-miner/tracker-miner-object.c
index beb4792..d82396f 100644
--- a/src/libtracker-miner/tracker-miner-object.c
+++ b/src/libtracker-miner/tracker-miner-object.c
@@ -90,7 +90,6 @@ enum {
 	PAUSED,
 	RESUMED,
 	PROGRESS,
-	ERROR,
 	IGNORE_NEXT_UPDATE,
 	LAST_SIGNAL
 };
@@ -221,23 +220,6 @@ tracker_miner_class_init (TrackerMinerClass *klass)
 		              G_TYPE_NONE, 2,
 		              G_TYPE_STRING,
 		              G_TYPE_DOUBLE);
-	/**
-	 * TrackerMiner::error:
-	 * @miner: the #TrackerMiner
-	 * @error: the error that happened
-	 *
-	 * The ::error signal will be emitted by TrackerMiner implementations to
-	 * indicate some error in the data mining process.
-	 **/
-	signals[ERROR] =
-		g_signal_new ("error",
-		              G_OBJECT_CLASS_TYPE (object_class),
-		              G_SIGNAL_RUN_LAST,
-		              G_STRUCT_OFFSET (TrackerMinerClass, error),
-		              NULL, NULL,
-		              g_cclosure_marshal_VOID__POINTER,
-		              G_TYPE_NONE, 1,
-		              G_TYPE_POINTER);
 
 	/**
 	 * TrackerMiner::ignore-next-update:
diff --git a/src/libtracker-miner/tracker-miner-object.h b/src/libtracker-miner/tracker-miner-object.h
index 16044cc..0280daa 100644
--- a/src/libtracker-miner/tracker-miner-object.h
+++ b/src/libtracker-miner/tracker-miner-object.h
@@ -80,9 +80,6 @@ typedef struct {
 	                             const gchar  *status,
 	                             gdouble       progress);
 
-	void (* error)              (TrackerMiner *miner,
-	                             GError       *error);
-
 	void (* ignore_next_update) (TrackerMiner *miner,
 	                             const GStrv   urls);
 } TrackerMinerClass;



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]