[evolution] Fix a potential uninitialized argument in e-plugin-python.c.



commit 0d17115d2c5669afd22c42a205e091330d8ef6d9
Author: Matthew Barnes <mbarnes redhat com>
Date:   Fri Jan 15 21:51:35 2010 -0500

    Fix a potential uninitialized argument in e-plugin-python.c.
    
    	if (PyCallable_Check (priv->pClass))
    		pInstance = PyObject_CallObject (priv->pClass, NULL);
    
    	pValue = PyObject_CallMethod (pInstance, (gchar *) name, NULL);
    
    'pInstance' may be uninitialzed in call to PyObject_CallMethod().
    
    Found by the Clang Static Analyzer.

 modules/plugin-python/e-plugin-python.c |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)
---
diff --git a/modules/plugin-python/e-plugin-python.c b/modules/plugin-python/e-plugin-python.c
index 747ba57..6971a35 100644
--- a/modules/plugin-python/e-plugin-python.c
+++ b/modules/plugin-python/e-plugin-python.c
@@ -101,7 +101,7 @@ plugin_python_invoke (EPlugin *plugin,
 	EPluginPython *plugin_python;
 	EPluginPythonPrivate *priv;
 	PyObject *pModuleName, *pFunc;
-	PyObject *pInstance, *pValue = NULL;
+	PyObject *pValue = NULL;
 
 	plugin_python = E_PLUGIN_PYTHON (plugin);
 	priv = plugin_python->priv;
@@ -144,10 +144,12 @@ plugin_python_invoke (EPlugin *plugin,
 
 	if (priv->pClass) {
 
-		if (PyCallable_Check (priv->pClass))
-			pInstance = PyObject_CallObject (priv->pClass, NULL);
+		if (PyCallable_Check (priv->pClass)) {
+			PyObject *pInstance;
 
-		pValue = PyObject_CallMethod (pInstance, (gchar *) name, NULL);
+			pInstance = PyObject_CallObject (priv->pClass, NULL);
+			pValue = PyObject_CallMethod (pInstance, (gchar *) name, NULL);
+		}
 
 	} else {
 



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]