[xchat-gnome] Bug 599781 - DCC transfers always time out by default.



commit 3982672d0bfda9a6f8ad6b2109ddf03a3dd92688
Author: Adam Buchbinder <adam buchbinder gmail com>
Date:   Thu Jan 14 18:24:07 2010 +0530

    Bug 599781 -  DCC transfers always time out by default.
    
    On a fresh install of xchat-gnome (no ~/.xchat2 directory), requesting a file
    via XDCC fails. This is because xchat-gnome sets the preference dcc_auto_send
    to 2 by default; when the setting is set manually, it's set to 1.
    ("dcc_auto_send" is a misnomer; it should be called "dcc_auto_receive".)
    However, when autoreceive is disabled, it's set to 0, not 2. To sum up:
    
    dcc_auto_send = 0 -> ("No") File is added to the receive window in "waiting"
    state. (Can hit a button to start it.)
    dcc_auto_send = 1 -> ("Yes") File is added to the receive window in "active"
    state, starts downloading.
    dcc_auto_send = 2 -> ("Browse for save folder every time") File is added to the
    receive window in "waiting" state, save-as dialog pops up.

 src/common/cfgfiles.c     |    2 +-
 src/fe-gnome/dcc-window.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/src/common/cfgfiles.c b/src/common/cfgfiles.c
index bca068f..6c70727 100644
--- a/src/common/cfgfiles.c
+++ b/src/common/cfgfiles.c
@@ -679,7 +679,7 @@ load_config (void)
 	prefs.bantype = 2;
 	prefs.input_flash_priv = prefs.input_flash_hilight = 1;
 	prefs.input_tray_priv = prefs.input_tray_hilight = 1;
-	prefs.autodccsend = 2;	/* browse mode */
+	prefs.autodccsend = 0;	/* disable auto send */
 #ifdef WIN32
 	prefs.identd = 1;
 #endif
diff --git a/src/fe-gnome/dcc-window.c b/src/fe-gnome/dcc-window.c
index 463a974..92f2026 100644
--- a/src/fe-gnome/dcc-window.c
+++ b/src/fe-gnome/dcc-window.c
@@ -207,7 +207,7 @@ dcc_window_add (DccWindow *window, struct DCC *dcc)
 
 	/* If this is a recieve and auto-accept isn't turned on, pop up a
 	 * confirmation dialog */
-	if ((dcc->type == TYPE_RECV) && (dcc->dccstat == STAT_QUEUED) && (prefs.autodccsend == FALSE)) {
+	if ((dcc->type == TYPE_RECV) && (dcc->dccstat == STAT_QUEUED) && (prefs.autodccsend != 1)) {
 		GtkWidget *dialog;
 		gint response;
 



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]