[gdm] Fix ellipses usage on User Switch Applet



commit c249a06a8ca772051c17cef7c9c115e027146bea
Author: Michael Monreal <michael monreal+bugs gmail com>
Date:   Wed Jan 13 12:08:42 2010 -0500

    Fix ellipses usage on User Switch Applet
    
    "Account Information" and "System Preferences" have ellipses "..." on the User
    Switch Applet. Those are normally meant to indicate that part of the action
    needs further user input. Both of these just open some app, so IMHO the
    ellipses are not needed here: the action is complete when the app is started
    (Edit->Preferences in GNOME apps does not have ellipses for this same reason)
    
    The HIG says:
    
    ---
    Label the menu item with a trailing ellipsis ("...") only if the command
    requires further input from the user before it can be performed. Do not add an
    ellipsis to items that only present a confirmation dialog (such as Delete), or
    that do not require further input (such as Properties, Preferences or About).
    ---
    
    See: https://bugzilla.gnome.org/show_bug.cgi?id=568866

 gui/user-switch-applet/applet.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/gui/user-switch-applet/applet.c b/gui/user-switch-applet/applet.c
index f213a07..2c364f1 100644
--- a/gui/user-switch-applet/applet.c
+++ b/gui/user-switch-applet/applet.c
@@ -1128,7 +1128,7 @@ create_sub_menu (GdmAppletData *adata)
         gtk_widget_show (item);
 #endif
 
-        adata->account_item = gtk_image_menu_item_new_with_label (_("Account Information..."));
+        adata->account_item = gtk_image_menu_item_new_with_label (_("Account Information"));
         gtk_image_menu_item_set_image (GTK_IMAGE_MENU_ITEM (adata->account_item),
                                        gtk_image_new ());
         gtk_menu_shell_append (GTK_MENU_SHELL (adata->menu),
@@ -1140,7 +1140,7 @@ create_sub_menu (GdmAppletData *adata)
         gtk_widget_show (adata->account_item);
 
 
-        adata->control_panel_item = gtk_image_menu_item_new_with_label (_("System Preferences..."));
+        adata->control_panel_item = gtk_image_menu_item_new_with_label (_("System Preferences"));
         gtk_image_menu_item_set_image (GTK_IMAGE_MENU_ITEM (adata->control_panel_item),
                                        gtk_image_new ());
         gtk_menu_shell_append (GTK_MENU_SHELL (adata->menu),



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]