[gtksourceviewmm/devel] Add some TODOs.
- From: Krzesimir Nowak <krnowak src gnome org>
- To: svn-commits-list gnome org
- Cc:
- Subject: [gtksourceviewmm/devel] Add some TODOs.
- Date: Wed, 13 Jan 2010 00:10:21 +0000 (UTC)
commit 860e085d96788602be0157969fded2a5424b2529
Author: Krzesimir Nowak <qdlacz gmail com>
Date: Wed Jan 13 00:58:48 2010 +0100
Add some TODOs.
* gtksourceview/src/sourcebuffer.hg:
* gtksourceview/src/sourcegutter.hg:
* gtksourceview/src/sourcelanguage.hg:
* gtksourceview/src/sourcemark.hg:
* gtksourceview/src/sourceview.hg: Added some TODOs, mostly
regarding adding/removing stuff when API/ABI break will come.
gtksourceview/src/sourcebuffer.hg | 1 +
gtksourceview/src/sourcegutter.hg | 6 ++++--
gtksourceview/src/sourcelanguage.hg | 1 +
gtksourceview/src/sourcemark.hg | 1 +
gtksourceview/src/sourceview.hg | 2 +-
5 files changed, 8 insertions(+), 3 deletions(-)
---
diff --git a/gtksourceview/src/sourcebuffer.hg b/gtksourceview/src/sourcebuffer.hg
index 46e9332..31f53e8 100644
--- a/gtksourceview/src/sourcebuffer.hg
+++ b/gtksourceview/src/sourcebuffer.hg
@@ -52,6 +52,7 @@ class SourceBuffer : public Gtk::TextBuffer
_CLASS_GOBJECT(SourceBuffer, GtkSourceBuffer, GTK_SOURCE_BUFFER, Gtk::TextBuffer, GtkTextBuffer)
protected:
+ // TODO: C API does not provide default constructor for GtkSourceBuffer, should we delete it on API/ABI break? krnowak
_CTOR_DEFAULT
explicit SourceBuffer (const Glib::RefPtr<Gtk::TextTagTable>& tag_table) ;
diff --git a/gtksourceview/src/sourcegutter.hg b/gtksourceview/src/sourcegutter.hg
index f3f0b16..216f48f 100644
--- a/gtksourceview/src/sourcegutter.hg
+++ b/gtksourceview/src/sourcegutter.hg
@@ -40,10 +40,12 @@ class SourceGutter : public Glib::Object
_CLASS_GOBJECT(SourceGutter, GtkSourceGutter, GTK_SOURCE_GUTTER, Glib::Object, GObject)
protected:
- _CTOR_DEFAULT
+ // TODO: C API does not provide any constructor for GtkSourceGutter, should we delete it on API/ABI break? krnowak
+ _CTOR_DEFAULT
public:
- _WRAP_CREATE()
+ // TODO: C API does not provide any constructor for GtkSourceGutter, should we delete it on API/ABI break? krnowak
+ _WRAP_CREATE
_WRAP_METHOD(Glib::RefPtr<Gdk::Window> get_window(), gtk_source_gutter_get_window, refreturn)
_WRAP_METHOD(Glib::RefPtr<const Gdk::Window> get_window() const, gtk_source_gutter_get_window, constversion, refreturn)
diff --git a/gtksourceview/src/sourcelanguage.hg b/gtksourceview/src/sourcelanguage.hg
index e2abeab..41e209b 100644
--- a/gtksourceview/src/sourcelanguage.hg
+++ b/gtksourceview/src/sourcelanguage.hg
@@ -50,6 +50,7 @@ protected:
public:
+ // TODO: C API does not provide any constructor for GtkSourceLanguage, should we delete it on API/ABI break? krnowak
/// \brief create a language.
///
/// \return the newly created language
diff --git a/gtksourceview/src/sourcemark.hg b/gtksourceview/src/sourcemark.hg
index daeabba..34ecf8b 100644
--- a/gtksourceview/src/sourcemark.hg
+++ b/gtksourceview/src/sourcemark.hg
@@ -33,6 +33,7 @@ class SourceMark : public Gtk::TextMark
_CLASS_GOBJECT(SourceMark, GtkSourceMark, GTK_SOURCE_MARK, Gtk::TextMark, GtkTextMark)
protected:
+ // TODO: C API does not provide default constructor for GtkSourceMark, should we delete it on API/ABI break? krnowak
_CTOR_DEFAULT
//We reversed the parameter order, because name can be NULL:
diff --git a/gtksourceview/src/sourceview.hg b/gtksourceview/src/sourceview.hg
index 3873bda..bcafbca 100644
--- a/gtksourceview/src/sourceview.hg
+++ b/gtksourceview/src/sourceview.hg
@@ -60,7 +60,7 @@ public:
/// \param buffer the buffer to display in the SourceView
explicit SourceView (const Glib::RefPtr<SourceBuffer> &buffer) ;
-// TODO: remove these when breaking API/ABI?
+// TODO: remove these when breaking API/ABI? SourceView is derived from GtkObject, so it does not need to be accessed by Glib::RefPtr. krnowak
_WRAP_CREATE()
_WRAP_CREATE(const Glib::RefPtr<SourceBuffer> &buffer)
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]