[gnome-control-center/gnome-2-28] [common] Don't leak file descriptors when checking for colour schemes



commit e0e19c5fc7b9717eb462519ebdb2c0deda571644
Author: Jens Granseuer <jensgr gmx net>
Date:   Wed Jan 6 21:43:29 2010 +0100

    [common] Don't leak file descriptors when checking for colour schemes
    
    Closes bug #606155.

 capplets/common/gtkrc-utils.c |   17 ++++++++++-------
 1 files changed, 10 insertions(+), 7 deletions(-)
---
diff --git a/capplets/common/gtkrc-utils.c b/capplets/common/gtkrc-utils.c
index 72f0322..f5429ac 100644
--- a/capplets/common/gtkrc-utils.c
+++ b/capplets/common/gtkrc-utils.c
@@ -212,15 +212,18 @@ gtkrc_get_color_scheme (const gchar *gtkrc_file)
 			{
 				if (GINT_TO_POINTER (token) == COLOR_SCHEME_SYMBOL)
 				{
-					if (g_scanner_get_next_token (scanner) != '=')
-						continue;
-					token = g_scanner_get_next_token (scanner);
-					if (token != G_TOKEN_STRING)
-						continue;
-					g_free (result);
-					result = g_strdup (scanner->value.v_string);
+					if (g_scanner_get_next_token (scanner) == '=')
+					{
+						token = g_scanner_get_next_token (scanner);
+						if (token == G_TOKEN_STRING)
+						{
+							g_free (result);
+							result = g_strdup (scanner->value.v_string);
+						}
+					}
 				}
 			}
+			close (file);
 		}
 	}
 



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]