[dia] [scan-build] Dead assignment
- From: Hans Breuer <hans src gnome org>
- To: svn-commits-list gnome org
- Cc:
- Subject: [dia] [scan-build] Dead assignment
- Date: Sat, 2 Jan 2010 14:46:31 +0000 (UTC)
commit 16612118ea3d7afbe7a070b874adbdbf0cf66b13
Author: Hans Breuer <hans breuer org>
Date: Fri Jan 1 16:28:03 2010 +0100
[scan-build] Dead assignment
Value stored to 'ddisp' is never read
Value stored to 'duplicate_corner' is never read
Value stored to 'high' during its initialization is never read
app/app_procs.c | 3 +--
app/commands.c | 5 +----
2 files changed, 2 insertions(+), 6 deletions(-)
---
diff --git a/app/app_procs.c b/app/app_procs.c
index 907efac..2ddeb4a 100644
--- a/app/app_procs.c
+++ b/app/app_procs.c
@@ -533,7 +533,6 @@ handle_initial_diagram(const char *in_file_name,
const char *size,
char* show_layers,
const char *outdir) {
- DDisplay *ddisp = NULL;
Diagram *diagram = NULL;
gboolean made_conversions = FALSE;
@@ -583,7 +582,7 @@ handle_initial_diagram(const char *in_file_name,
if (app_is_interactive()) {
layer_dialog_set_diagram(diagram);
/* the display initial diagram holds two references */
- ddisp = new_display(diagram);
+ new_display(diagram);
} else {
g_object_unref(diagram);
}
diff --git a/app/commands.c b/app/commands.c
index 19614e5..7eded3c 100644
--- a/app/commands.c
+++ b/app/commands.c
@@ -137,14 +137,13 @@ void
file_new_callback (GtkAction *action)
{
Diagram *dia;
- DDisplay *ddisp;
static int untitled_nr = 1;
gchar *name, *filename;
name = g_strdup_printf(_("Diagram%d.dia"), untitled_nr++);
filename = g_filename_from_utf8(name, -1, NULL, NULL, NULL);
dia = new_diagram(filename);
- ddisp = new_display(dia);
+ new_display(dia);
dia_diagram_add (dia); /* notify DiagramTree etc. */
g_free (name);
g_free (filename);
@@ -380,14 +379,12 @@ edit_duplicate_callback (GtkAction *action)
{
GList *duplicate_list;
DDisplay *ddisp;
- Point duplicate_corner;
Point delta;
Change *change;
ddisp = ddisplay_active();
if (!ddisp || textedit_mode(ddisp)) return;
duplicate_list = object_copy_list(diagram_get_sorted_selected(ddisp->diagram));
- duplicate_corner = object_list_corner(duplicate_list);
/* Move down some 10% of the visible area. */
delta.x = (ddisp->visible.right - ddisp->visible.left)*0.05;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]