[gtksourceviewmm] Update TODOs.

From: Krzesimir Nowak <krnowak src gnome org>
To: commits-list gnome org
Cc:
Subject: [gtksourceviewmm] Update TODOs.
Date: Fri, 26 Feb 2010 13:26:57 +0000 (UTC)
commit 0103ead6b2a94c63f86e7121b2642f0b60360108
Author: Krzesimir Nowak <qdlacz gmail com>
Date:   Thu Feb 25 19:25:30 2010 +0100

    Update TODOs.
    
    * gtksourceview/src/sourcebuffer.ccg:
    * gtksourceview/src/sourcebuffer.hg:
    * gtksourceview/src/sourcecompletion.hg:
    * gtksourceview/src/sourcecompletionactivation.hg:
    * gtksourceview/src/sourcecompletioncontext.hg:
    * gtksourceview/src/sourcecompletionitem.hg:
    * gtksourceview/src/sourcecompletionproposal.hg:
    * gtksourceview/src/sourcecompletionprovider.hg:
    * gtksourceview/src/sourcecompletionwords.hg:
    * gtksourceview/src/sourcelanguagemanager.hg:
    * gtksourceview/src/sourcemark.hg:
    * gtksourceview/src/sourcestylescheme.hg:
    * gtksourceview/src/sourceundomanager.hg:
    * gtksourceview/src/sourceview.hg: All of TODO were written by me,
    some 'krnowak' was appended to them. Also added some new ones.

 gtksourceview/src/sourcebuffer.ccg              |    2 +-
 gtksourceview/src/sourcebuffer.hg               |    2 +-
 gtksourceview/src/sourcecompletion.hg           |    8 ++++----
 gtksourceview/src/sourcecompletionactivation.hg |    2 +-
 gtksourceview/src/sourcecompletioncontext.hg    |    2 +-
 gtksourceview/src/sourcecompletionitem.hg       |    4 ++--
 gtksourceview/src/sourcecompletionproposal.hg   |    2 ++
 gtksourceview/src/sourcecompletionprovider.hg   |    2 ++
 gtksourceview/src/sourcecompletionwords.hg      |    4 ++--
 gtksourceview/src/sourcelanguagemanager.hg      |    2 +-
 gtksourceview/src/sourcemark.hg                 |    4 +---
 gtksourceview/src/sourcestylescheme.hg          |    2 +-
 gtksourceview/src/sourceundomanager.hg          |    3 +++
 gtksourceview/src/sourceview.hg                 |    2 +-
 14 files changed, 23 insertions(+), 18 deletions(-)
---
diff --git a/gtksourceview/src/sourcebuffer.ccg b/gtksourceview/src/sourcebuffer.ccg
index 994b7f5..edbc6ef 100644
--- a/gtksourceview/src/sourcebuffer.ccg
+++ b/gtksourceview/src/sourcebuffer.ccg
@@ -33,7 +33,7 @@ SourceBuffer::SourceBuffer (const Glib::RefPtr<Gtk::TextTagTable>& tag_table) :
   _CONSTRUCT("tag-table", Glib::unwrap(tag_table))
 {}
 
-// TODO: check later how bug 606732 goes.
+// TODO: check later how bug 606732 goes. krnowak
 SourceBuffer::SourceBuffer (const Glib::RefPtr<SourceLanguage> &language) :
 //    _CONSTRUCT("tag-table, 0")
     _CONSTRUCT("tag-table", 0, "language", Glib::unwrap(language))
diff --git a/gtksourceview/src/sourcebuffer.hg b/gtksourceview/src/sourcebuffer.hg
index 8ef4512..a75a782 100644
--- a/gtksourceview/src/sourcebuffer.hg
+++ b/gtksourceview/src/sourcebuffer.hg
@@ -441,7 +441,7 @@ public:
    */
   _WRAP_SIGNAL(void highlight_updated(Gtk::TextIter& start, Gtk::TextIter& end), "highlight-updated", no_default_handler)
 
-// TODO: Use lower _CONVERSION/_WRAP_SIGNAL when we break API/ABI and remove upper ones.
+// TODO: Use lower _CONVERSION/_WRAP_SIGNAL when we break API/ABI and remove upper ones. krnowak
 #m4 _CONVERSION(`GtkTextMark*',`const Glib::RefPtr<SourceMark>&',`Glib::RefPtr<SourceMark>::cast_dynamic(Glib::wrap($3, true))')
 //#m4 _CONVERSION(`GtkTextMark*',`const Glib::RefPtr<Gtk::TextMark>&',`Glib::wrap($3, true)')
   /** Emitted whenever a marker of sourcebuffer has changed and needs to be redisplayed by the view.
diff --git a/gtksourceview/src/sourcecompletion.hg b/gtksourceview/src/sourcecompletion.hg
index 6e4678a..156e0da 100644
--- a/gtksourceview/src/sourcecompletion.hg
+++ b/gtksourceview/src/sourcecompletion.hg
@@ -68,7 +68,7 @@ public:
   _WRAP_METHOD(bool remove_provider(const Glib::RefPtr<SourceCompletionProvider>& provider), gtk_source_completion_remove_provider, errthrow)
 
 #m4 _CONVERSION(`GList*',`Glib::ListHandle<Glib::RefPtr<SourceCompletionProvider> >',`$2($3, Glib::OWNERSHIP_NONE)')
-  // TODO: is conversion all right? C docs states: "The returned list is owned by the completion and should not be freed."
+  // TODO: is conversion all right? C docs states: "The returned list is owned by the completion and should not be freed." krnowak
   /** Get list of providers registered on completion.
    *
    * @return List of SourceCompletionProvider.
@@ -78,7 +78,7 @@ public:
   _WRAP_METHOD(Glib::ListHandle<Glib::RefPtr<SourceCompletionProvider> > get_providers() const, gtk_source_completion_get_providers)
 
 #m4 _CONVERSION(`const Glib::ListHandle<Glib::RefPtr<SourceCompletionProvider> >&',`GList*',`($3).data()')
-  // TODO: what does passing NULL here does? If something specific, then maybe create separate method passing it.
+  // TODO: what does passing NULL here does? If something specific, then maybe create separate method passing it. krnowak
   /** Starts a new completion with the specified SourceCompletionContext and
    *  a list of potential candidate providers for completion.
    *
@@ -116,7 +116,7 @@ public:
    */
   _WRAP_METHOD(SourceView* get_view() const, gtk_source_completion_get_view)
 
-  // TODO: Does "The reference being returned is a 'floating' reference, so if you invoke gtk_source_completion_show with this context you don't need to unref it." something mean for us?
+  // TODO: Does "The reference being returned is a 'floating' reference, so if you invoke gtk_source_completion_show with this context you don't need to unref it." something mean for us? krnowak
   /** Create a new SourceCompletionContext for completion.
    *
    * The position at which the completion using the new context will consider
@@ -130,7 +130,7 @@ public:
    */
   _WRAP_METHOD(Glib::RefPtr<SourceCompletionContext> create_context(const Gtk::TextIter& position), gtk_source_completion_create_context)
 
-  // TODO: better wording could be used here - it is too convoluted.
+  // TODO: better wording could be used here - it is too convoluted. krnowak
   /** Create a new SourceCompletionContext for completion.
    *
    * The position at which the completion using the new context will consider
diff --git a/gtksourceview/src/sourcecompletionactivation.hg b/gtksourceview/src/sourcecompletionactivation.hg
index 94033f4..df89b72 100644
--- a/gtksourceview/src/sourcecompletionactivation.hg
+++ b/gtksourceview/src/sourcecompletionactivation.hg
@@ -21,7 +21,7 @@ _DEFS(gtksourceviewmm,gtksourceview)
 
 namespace gtksourceview
 {
-// TODO: need docs.
+// TODO: need docs. krnowak
 /** An enum type specifying something bla bla bla, probably type of activation.
  *
  * @newin{2,10}
diff --git a/gtksourceview/src/sourcecompletioncontext.hg b/gtksourceview/src/sourcecompletioncontext.hg
index 925f81b..b634eaa 100644
--- a/gtksourceview/src/sourcecompletioncontext.hg
+++ b/gtksourceview/src/sourcecompletioncontext.hg
@@ -38,7 +38,7 @@ class SourceCompletionProvider;
 class SourceCompletion;
 class SourceView;
 
-// TODO: need docs here.
+// TODO: need docs here. krnowak
 /** SourceCompletionContext
  *
  * @newin{2,10}
diff --git a/gtksourceview/src/sourcecompletionitem.hg b/gtksourceview/src/sourcecompletionitem.hg
index 3f16b9b..9c830fb 100644
--- a/gtksourceview/src/sourcecompletionitem.hg
+++ b/gtksourceview/src/sourcecompletionitem.hg
@@ -29,7 +29,7 @@ _PINCLUDE(glibmm/private/object_p.h)
 namespace gtksourceview
 {
 
-// TODO: need docs here.
+// TODO: need docs here. krnowak
 /** SourceCompletionItem
  *
  * @newin{2,10}
@@ -48,7 +48,7 @@ protected:
 public:
   /** Create a new SourceCompletionItem with label @a label, icon @a icon and
    *  extra information @a info.
-   *
+   *;
    * If @a icon is empty, then there will be no icon shown. If @a info is empty,
    * then no extra information will be available.
    *
diff --git a/gtksourceview/src/sourcecompletionproposal.hg b/gtksourceview/src/sourcecompletionproposal.hg
index 2e08005..0ba478a 100644
--- a/gtksourceview/src/sourcecompletionproposal.hg
+++ b/gtksourceview/src/sourcecompletionproposal.hg
@@ -142,6 +142,8 @@ public:
    */
   _WRAP_SIGNAL(void changed(), "changed")
 
+// TODO: should vfuncs be protected? krnowak
+
   _WRAP_VFUNC(Glib::ustring get_label() const, get_label)
 
   _WRAP_VFUNC(Glib::ustring get_markup() const, get_markup)
diff --git a/gtksourceview/src/sourcecompletionprovider.hg b/gtksourceview/src/sourcecompletionprovider.hg
index e028118..a28b025 100644
--- a/gtksourceview/src/sourcecompletionprovider.hg
+++ b/gtksourceview/src/sourcecompletionprovider.hg
@@ -177,6 +177,8 @@ public:
    */
   _WRAP_METHOD(int get_priority() const, gtk_source_completion_provider_get_priority)
 
+// TODO: should vfuncs be protected? krnowak
+
   _WRAP_VFUNC(Glib::ustring get_name() const, get_name)
 
   _WRAP_VFUNC(Glib::RefPtr<Gdk::Pixbuf> get_icon(), get_icon, refreturn)
diff --git a/gtksourceview/src/sourcecompletionwords.hg b/gtksourceview/src/sourcecompletionwords.hg
index 50e8182..c1def3d 100644
--- a/gtksourceview/src/sourcecompletionwords.hg
+++ b/gtksourceview/src/sourcecompletionwords.hg
@@ -25,7 +25,7 @@ _PINCLUDE(glibmm/private/object_p.h)
 
 namespace gtksourceview
 {
-// TODO: docs needed.
+// TODO: docs needed. krnowak
 /** Words completion provider.
  *
  * @newin{2,10}
@@ -49,7 +49,7 @@ public:
    */
   _WRAP_CREATE(const Glib::ustring& name, const Glib::RefPtr<Gdk::Pixbuf>& icon)
 
-// TODO: think about a good method name - register is a C/C++ keyword.
+// TODO: think about a good method name - register is a C/C++ keyword. krnowak
   /** Registers this provider in given buffer.
    *
    * @param buffer A buffer which will use this provider.
diff --git a/gtksourceview/src/sourcelanguagemanager.hg b/gtksourceview/src/sourcelanguagemanager.hg
index 0368da4..40b94c6 100644
--- a/gtksourceview/src/sourcelanguagemanager.hg
+++ b/gtksourceview/src/sourcelanguagemanager.hg
@@ -127,7 +127,7 @@ public:
    */
   _WRAP_METHOD(Glib::RefPtr<const SourceLanguage> get_language(const Glib::ustring& id) const, gtk_source_language_manager_get_language, constversion, refreturn)
   _IGNORE(gtk_source_language_manager_guess_language)
-// TODO: change filename parameter to std::string, when we break API/ABI.
+// TODO: change filename parameter to std::string, when we break API/ABI. krnowak
   /** Picks a SourceLanguage for given file name and content type,
    *  according to the information in lang files.
    *
diff --git a/gtksourceview/src/sourcemark.hg b/gtksourceview/src/sourcemark.hg
index 0acbc18..e91426e 100644
--- a/gtksourceview/src/sourcemark.hg
+++ b/gtksourceview/src/sourcemark.hg
@@ -38,9 +38,7 @@ protected:
   // TODO: C API does not provide default constructor for GtkSourceMark, should we delete it on API/ABI break? krnowak
    _CTOR_DEFAULT
 
-  /* TODO: When breaking API/ABI add a constructor getting only category parameter to allow explicit anonymous mark creation and empty string names.
-   *       Maybe also return to normal order of parameters. Does it have sense?
-   *       krnowak
+  /* TODO: When breaking API/ABI add a constructor getting only category parameter to allow explicit anonymous mark creation and empty string names. Maybe also return to normal order of parameters. Does it have sense? krnowak
    */
   // We reversed the parameter order, because name can be NULL:
   explicit SourceMark(const Glib::ustring& category, const Glib::ustring& name = Glib::ustring());
diff --git a/gtksourceview/src/sourcestylescheme.hg b/gtksourceview/src/sourcestylescheme.hg
index b44b348..9a53154 100644
--- a/gtksourceview/src/sourcestylescheme.hg
+++ b/gtksourceview/src/sourcestylescheme.hg
@@ -49,7 +49,7 @@ class SourceStyleScheme : public Glib::Interface
 
   _CLASS_INTERFACE(SourceStyleScheme, GtkSourceStyleScheme, GTK_SOURCE_STYLE_SCHEME, GTypeInterface)
 
-// TODO: This is wrong. GtkSourceStyleScheme is not an interface. Changing this breaks API.
+// TODO: This is wrong. GtkSourceStyleScheme is not an interface. Changing this breaks API. krnowak
 /*
 class SourceStyleScheme : public Glib::Object
 {
diff --git a/gtksourceview/src/sourceundomanager.hg b/gtksourceview/src/sourceundomanager.hg
index 69cc357..f46e8fb 100644
--- a/gtksourceview/src/sourceundomanager.hg
+++ b/gtksourceview/src/sourceundomanager.hg
@@ -105,6 +105,7 @@ public:
    */
   _WRAP_METHOD(void can_redo_changed(), gtk_source_undo_manager_can_redo_changed)
 
+  // TODO: should these signals be wrapped? They are marked as action ones. krnowak
   /** Emitted when the ability to undo has changed.
    */
   _WRAP_SIGNAL(void can_undo_changed(), "can-undo-changed")
@@ -113,6 +114,8 @@ public:
    */
   _WRAP_SIGNAL(void can_redo_changed(), "can-redo-changed")
 
+// TODO: should vfuncs be protected? krnowak
+
   _WRAP_VFUNC(bool can_undo() const, can_undo)
 
   _WRAP_VFUNC(bool can_redo() const, can_redo)
diff --git a/gtksourceview/src/sourceview.hg b/gtksourceview/src/sourceview.hg
index dffc070..ba257bd 100644
--- a/gtksourceview/src/sourceview.hg
+++ b/gtksourceview/src/sourceview.hg
@@ -524,7 +524,7 @@ public:
   /** Emitted when undo action is requested.
    */
   _WRAP_SIGNAL(void undo(), "undo")
-// TODO: remove no_default_handler when we will break API/ABI.
+// TODO: remove no_default_handler when we will break API/ABI. krnowak
 
   /** Emitted when a line mark has been activated (for instance when there
    * was a button press in the line marks gutter).
[Date Prev][Date Next] [Thread Prev][Thread Next] [Thread Index] [Date Index] [Author Index]