[giggle] Fix a crash when searching
- From: Javier Jardón <jjardon src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [giggle] Fix a crash when searching
- Date: Fri, 26 Feb 2010 03:59:57 +0000 (UTC)
commit 3391881ff1d9b7f0700e71c3716ce5ef64163c82
Author: Javier Jardón <jjardon gnome org>
Date: Fri Feb 26 04:57:39 2010 +0100
Fix a crash when searching
Author property is now a GiggleAuthor object, so we should use
g_object_unref() instead g_free()
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=572155
src/giggle-rev-list-view.c | 19 +++++++++++++------
1 files changed, 13 insertions(+), 6 deletions(-)
---
diff --git a/src/giggle-rev-list-view.c b/src/giggle-rev-list-view.c
index 2423b9e..bde6b24 100644
--- a/src/giggle-rev-list-view.c
+++ b/src/giggle-rev-list-view.c
@@ -675,13 +675,20 @@ giggle_rev_list_view_class_init (GiggleRevListViewClass *class)
static gboolean
revision_property_matches (GiggleRevision *revision,
- const gchar *property,
- const gchar *search_term)
+ const gchar *property,
+ const gchar *search_term)
{
- gboolean match;
- gchar *str, *casefold_str;
-
- g_object_get (revision, property, &str, NULL);
+ GiggleAuthor *author;
+ gboolean match;
+ gchar *str, *casefold_str;
+
+ if (g_strcmp0 ("author", property) == 0) {
+ g_object_get (revision, "author", &author, NULL);
+ g_object_get (author, "name", &str, NULL);
+ g_object_unref (author);
+ } else if (g_strcmp0 ("sha", property) == 0) {
+ g_object_get (revision, "sha", &str, NULL);
+ }
casefold_str = g_utf8_casefold (str, -1);
match = strstr (casefold_str, search_term) != NULL;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]