[banshee/gapless-ng: 834/836] [libbanshee] Fix warning about disposing rgvolume.
- From: Christopher James Halse Rogers <chrishr src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [banshee/gapless-ng: 834/836] [libbanshee] Fix warning about disposing rgvolume.
- Date: Thu, 25 Feb 2010 22:45:59 +0000 (UTC)
commit c13909bfbf10534daaadd301bcd5734917d36109
Author: Christopher James Halse Rogers <raof ubuntu com>
Date: Thu Feb 25 15:16:11 2010 +1100
[libbanshee] Fix warning about disposing rgvolume.
Removing rgvolume from the audiobin also g_object_unref's it. GStreamer then complains
that it is being disposed without first setting its state to NULL.
Fixes that warning when disabling ReplayGain
libbanshee/banshee-player-replaygain.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
---
diff --git a/libbanshee/banshee-player-replaygain.c b/libbanshee/banshee-player-replaygain.c
index fc1ac45..8871c70 100644
--- a/libbanshee/banshee-player-replaygain.c
+++ b/libbanshee/banshee-player-replaygain.c
@@ -109,6 +109,7 @@ pad_block_cb (GstPad *srcPad, gboolean blocked, gpointer user_data) {
if (player->replaygain_enabled) {
player->rgvolume = _bp_rgvolume_new (player);
} else {
+ gst_element_set_state (player->rgvolume, GST_STATE_NULL);
gst_bin_remove (GST_BIN (player->audiobin), player->rgvolume);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]