[banshee/gapless-ng: 825/836] [Banshee.MediaEngine] Handle SetNextTrack (null) correctly.



commit 62774c61645608ade397ecb519e1a0ae643a5b19
Author: Christopher James Halse Rogers <raof ubuntu com>
Date:   Thu Feb 11 17:26:03 2010 +1100

    [Banshee.MediaEngine] Handle SetNextTrack (null) correctly.
    
    In the non-gapless codepath, SetNextTrack (null) would fall through the checks
    and cause OpenUri(null) then Play () to get called.  OpenUri (null) wouldn't do
    anything, but Play () would cause the last track to be repeated.
    
    This fixes the last regression reported on BGO #440952

 .../Banshee.MediaEngine/PlayerEngine.cs            |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)
---
diff --git a/src/Core/Banshee.Services/Banshee.MediaEngine/PlayerEngine.cs b/src/Core/Banshee.Services/Banshee.MediaEngine/PlayerEngine.cs
index e5f31b0..6e52287 100644
--- a/src/Core/Banshee.Services/Banshee.MediaEngine/PlayerEngine.cs
+++ b/src/Core/Banshee.Services/Banshee.MediaEngine/PlayerEngine.cs
@@ -121,8 +121,10 @@ namespace Banshee.MediaEngine
             if (current_state != PlayerState.Playing) {
                 // Pre-buffering the next track only makes sense when we're currently playing
                 // Instead, just open.
-                HandleOpen (uri);
-                Play ();
+                if (uri != null) {
+                    HandleOpen (uri);
+                    Play ();
+                }
                 return;
             }
 



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]