[banshee/gapless-ng: 9/836] Move responsibility for calling IncrementLastPlayed at end of track from PlayerEngineService.OpenChe



commit f8b383cf04bca8cc426ba434d66f244d22cad423
Author: Christopher James Halse Rogers <raof ubuntu com>
Date:   Fri Jul 17 16:35:19 2009 +1000

    Move responsibility for calling IncrementLastPlayed at end of track from PlayerEngineService.OpenCheck
    to PlaybackControllerService.

 .../Banshee.MediaEngine/PlayerEngineService.cs     |    8 ++++----
 .../PlaybackControllerService.cs                   |    4 +++-
 2 files changed, 7 insertions(+), 5 deletions(-)
---
diff --git a/src/Core/Banshee.Services/Banshee.MediaEngine/PlayerEngineService.cs b/src/Core/Banshee.Services/Banshee.MediaEngine/PlayerEngineService.cs
index f5d7062..358b334 100644
--- a/src/Core/Banshee.Services/Banshee.MediaEngine/PlayerEngineService.cs
+++ b/src/Core/Banshee.Services/Banshee.MediaEngine/PlayerEngineService.cs
@@ -245,6 +245,10 @@ namespace Banshee.MediaEngine
                     CurrentTrack.SavePlaybackError (StreamPlaybackError.None);
                 }
             }
+
+            if (args.Event == PlayerEvent.StartOfStream) {
+                incremented_last_played = false;
+            }
             
             RaiseEvent (args);
             
@@ -382,18 +386,14 @@ namespace Banshee.MediaEngine
                 return;
             }
 
-            IncrementLastPlayed ();
-            
             PlayerEngine supportingEngine = FindSupportingEngine (uri);
             SwitchToEngine (supportingEngine);
             CheckPending ();
             
             if (track != null) {
                 active_engine.Open (track);
-                incremented_last_played = false;
             } else if (uri != null) {
                 active_engine.Open (uri);
-                incremented_last_played = false;
             }
 
             if (play) {
diff --git a/src/Core/Banshee.Services/Banshee.PlaybackController/PlaybackControllerService.cs b/src/Core/Banshee.Services/Banshee.PlaybackController/PlaybackControllerService.cs
index 68fd047..b0fe4d1 100644
--- a/src/Core/Banshee.Services/Banshee.PlaybackController/PlaybackControllerService.cs
+++ b/src/Core/Banshee.Services/Banshee.PlaybackController/PlaybackControllerService.cs
@@ -236,7 +236,9 @@ namespace Banshee.PlaybackController
             Source = NextSource;
             raise_started_after_transition = true;
 
-            player_engine.IncrementLastPlayed ();
+            if (userRequested) {
+                player_engine.IncrementLastPlayed ();
+            }
             
             if (Source is IBasicPlaybackController && ((IBasicPlaybackController)Source).Next (restart, userRequested)) {
             } else {



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]