[gnome-color-manager] trivial: Report more errors in modal boxes, as most users won't be running with --verbose
- From: Richard Hughes <rhughes src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-color-manager] trivial: Report more errors in modal boxes, as most users won't be running with --verbose
- Date: Fri, 19 Feb 2010 15:47:58 +0000 (UTC)
commit 7dbb1e8c98286fc8b1e0226f6110a21d15384707
Author: Richard Hughes <richard hughsie com>
Date: Fri Feb 19 14:29:25 2010 +0000
trivial: Report more errors in modal boxes, as most users won't be running with --verbose
src/gcm-prefs.c | 40 +++++++++++++++++++++-------------------
1 files changed, 21 insertions(+), 19 deletions(-)
---
diff --git a/src/gcm-prefs.c b/src/gcm-prefs.c
index 3fcd2f6..53fe4d3 100644
--- a/src/gcm-prefs.c
+++ b/src/gcm-prefs.c
@@ -92,6 +92,23 @@ typedef enum {
static void gcm_prefs_devices_treeview_clicked_cb (GtkTreeSelection *selection, gpointer userdata);
/**
+ * gcm_prefs_error_dialog:
+ **/
+static void
+gcm_prefs_error_dialog (const gchar *title, const gchar *message)
+{
+ GtkWindow *window;
+ GtkWidget *dialog;
+
+ window = GTK_WINDOW(gtk_builder_get_object (builder, "dialog_prefs"));
+ dialog = gtk_message_dialog_new (window, GTK_DIALOG_MODAL, GTK_MESSAGE_ERROR, GTK_BUTTONS_CLOSE, "%s", title);
+ gtk_window_set_icon_name (GTK_WINDOW (dialog), GCM_STOCK_ICON);
+ gtk_message_dialog_format_secondary_text (GTK_MESSAGE_DIALOG (dialog), "%s", message);
+ gtk_dialog_run (GTK_DIALOG (dialog));
+ gtk_widget_destroy (dialog);
+}
+
+/**
* gcm_prefs_close_cb:
**/
static void
@@ -132,7 +149,8 @@ gcm_prefs_set_default (GcmDevice *device)
egg_debug ("running: %s", cmdline);
ret = g_spawn_command_line_sync (cmdline, NULL, NULL, NULL, &error);
if (!ret) {
- egg_warning ("failed to set default: %s", error->message);
+ /* TRANSLATORS: could not save for all users */
+ gcm_prefs_error_dialog (_("Failed to save defaults for all users"), error->message);
g_error_free (error);
goto out;
}
@@ -503,23 +521,6 @@ gcm_prefs_file_chooser_get_icc_profile (void)
}
/**
- * gcm_prefs_error_dialog:
- **/
-static void
-gcm_prefs_error_dialog (const gchar *title, const gchar *message)
-{
- GtkWindow *window;
- GtkWidget *dialog;
-
- window = GTK_WINDOW(gtk_builder_get_object (builder, "dialog_prefs"));
- dialog = gtk_message_dialog_new (window, GTK_DIALOG_MODAL, GTK_MESSAGE_ERROR, GTK_BUTTONS_CLOSE, "%s", title);
- gtk_window_set_icon_name (GTK_WINDOW (dialog), GCM_STOCK_ICON);
- gtk_message_dialog_format_secondary_text (GTK_MESSAGE_DIALOG (dialog), "%s", message);
- gtk_dialog_run (GTK_DIALOG (dialog));
- gtk_widget_destroy (dialog);
-}
-
-/**
* gcm_prefs_profile_import_file:
**/
static gboolean
@@ -812,7 +813,8 @@ gcm_prefs_delete_cb (GtkWidget *widget, gpointer data)
/* try to delete device */
ret = gcm_client_delete_device (gcm_client, current_device, &error);
if (!ret) {
- egg_warning ("failed to delete: %s", error->message);
+ /* TRANSLATORS: could not read file */
+ gcm_prefs_error_dialog (_("Failed to delete file"), error->message);
g_error_free (error);
}
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]