[gnome-packagekit] trivial: Show a warning when we fail to get update or package details



commit 91b7c67480ba7c56dad5d598416bde3e5b514e7d
Author: Richard Hughes <richard hughsie com>
Date:   Mon Feb 15 17:52:53 2010 +0000

    trivial: Show a warning when we fail to get update or package details

 src/gpk-update-viewer.c |   21 +++++++++++++++++----
 1 files changed, 17 insertions(+), 4 deletions(-)
---
diff --git a/src/gpk-update-viewer.c b/src/gpk-update-viewer.c
index 88679b6..cb9a6f7 100644
--- a/src/gpk-update-viewer.c
+++ b/src/gpk-update-viewer.c
@@ -2062,11 +2062,17 @@ gpk_update_viewer_get_details_cb (PkClient *client, GAsyncResult *res, GpkUpdate
 		goto out;
 	}
 
-	treeview = GTK_TREE_VIEW(gtk_builder_get_object (priv->builder, "treeview_updates"));
-	model = gtk_tree_view_get_model (treeview);
-
 	/* get data */
 	array = pk_results_get_details_array (results);
+	if (array->len == 0) {
+		/* TRANSLATORS: PackageKit did not send any results for the query... */
+		gpk_update_viewer_error_dialog (update_viewer, _("Could not get package details"), _("No results were returned."), NULL);
+		goto out;
+	}
+
+	/* set data */
+	treeview = GTK_TREE_VIEW(gtk_builder_get_object (priv->builder, "treeview_updates"));
+	model = gtk_tree_view_get_model (treeview);
 	for (i=0; i<array->len; i++) {
 		item = g_ptr_array_index (array, i);
 
@@ -2156,9 +2162,16 @@ gpk_update_viewer_get_update_detail_cb (PkClient *client, GAsyncResult *res, Gpk
 	}
 
 	/* get data */
+	array = pk_results_get_update_detail_array (results);
+	if (array->len == 0) {
+		/* TRANSLATORS: PackageKit did not send any results for the query... */
+		gpk_update_viewer_error_dialog (update_viewer, _("Could not get update details"), _("No results were returned."), NULL);
+		goto out;
+	}
+
+	/* add data */
 	treeview = GTK_TREE_VIEW(gtk_builder_get_object (priv->builder, "treeview_updates"));
 	model = gtk_tree_view_get_model (treeview);
-	array = pk_results_get_update_detail_array (results);
 	for (i=0; i<array->len; i++) {
 		item = g_ptr_array_index (array, i);
 



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]