[gthumb] Avoid return for void functions



commit dd1a194d9c51154d30500928c11d604ced6979d6
Author: jerry tan <jerry tan sun com>
Date:   Mon Feb 1 12:31:49 2010 +0100

    Avoid return for void functions
    
    [bug #608660]

 extensions/gstreamer/gstreamer-utils.c |    6 ++++--
 gthumb/gth-test.c                      |    2 +-
 2 files changed, 5 insertions(+), 3 deletions(-)
---
diff --git a/extensions/gstreamer/gstreamer-utils.c b/extensions/gstreamer/gstreamer-utils.c
index 776fa6b..6db6a21 100644
--- a/extensions/gstreamer/gstreamer-utils.c
+++ b/extensions/gstreamer/gstreamer-utils.c
@@ -703,12 +703,14 @@ get_current_frame_step2 (GstBuffer *buf,
 
 	if (buf == NULL) {
 		g_warning ("Could not take screenshot: %s", "conversion failed");
-		return screenshot_data_finalize (data);
+		screenshot_data_finalize (data);
+		return;
 	}
 
 	if (GST_BUFFER_CAPS (buf) == NULL) {
 		g_warning ("Could not take screenshot: %s", "no caps on output buffer");
-		return screenshot_data_finalize (data);
+		screenshot_data_finalize (data);
+		return;
 	}
 
 	s = gst_caps_get_structure (GST_BUFFER_CAPS (buf), 0);
diff --git a/gthumb/gth-test.c b/gthumb/gth-test.c
index 0236429..9a1c04b 100644
--- a/gthumb/gth-test.c
+++ b/gthumb/gth-test.c
@@ -430,7 +430,7 @@ gth_test_changed (GthTest *self)
 void
 gth_test_reset (GthTest *self)
 {
-	return GTH_TEST_GET_CLASS (self)->reset (self);
+	GTH_TEST_GET_CLASS (self)->reset (self);
 }
 
 



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]