[grilo] core: Added GError parameter to grl_plugin_registry_unregister_source

[Iago Toral Quiroga <itoral src gnome org>]

commit 689e6837e2d40ef672b1d840128714030febaaf7
Author: Iago Toral Quiroga <itoral igalia com>
Date:   Mon Dec 20 08:43:17 2010 +0100

    core: Added GError parameter to grl_plugin_registry_unregister_source

 src/grl-plugin-registry.c |   23 ++++++++++++++++++-----
 src/grl-plugin-registry.h |    7 ++++---
 2 files changed, 22 insertions(+), 8 deletions(-)
---
diff --git a/src/grl-plugin-registry.c b/src/grl-plugin-registry.c
index 06f9807..5c2eb11 100644
--- a/src/grl-plugin-registry.c
+++ b/src/grl-plugin-registry.c
@@ -331,17 +331,22 @@ grl_plugin_registry_register_source (GrlPluginRegistry *registry,
  * grl_plugin_registry_unregister_source:
  * @registry: the registry instance
  * @source: the source to unregister
+ * @error: error return location or @NULL to ignore
  *
  * Removes the @source from the @registry hash table
+ *
+ * Returns: %TRUE if success, %FALSE% otherwise.
  */
-void
+gboolean
 grl_plugin_registry_unregister_source (GrlPluginRegistry *registry,
-                                       GrlMediaPlugin *source)
+                                       GrlMediaPlugin *source,
+                                       GError **error)
 {
   gchar *id;
+  gboolean ret = TRUE;
 
-  g_return_if_fail (GRL_IS_PLUGIN_REGISTRY (registry));
-  g_return_if_fail (GRL_IS_MEDIA_PLUGIN (source));
+  g_return_val_if_fail (GRL_IS_PLUGIN_REGISTRY (registry), FALSE);
+  g_return_val_if_fail (GRL_IS_MEDIA_PLUGIN (source), FALSE);
 
   g_object_get (source, "source-id", &id, NULL);
   GRL_DEBUG ("Unregistering source '%s'", id);
@@ -352,7 +357,15 @@ grl_plugin_registry_unregister_source (GrlPluginRegistry *registry,
     g_object_unref (source);
   } else {
     GRL_WARNING ("source '%s' not found", id);
+    if (error) {
+      *error = g_error_new (GRL_CORE_ERROR,
+                            GRL_CORE_ERROR_UNREGISTER_SOURCE_FAILED,
+                            "Source with id '%s' was not found", id);
+    }
+    ret = FALSE;
   }
+
+  return ret;
 }
 
 /**
@@ -649,7 +662,7 @@ grl_plugin_registry_unload (GrlPluginRegistry *registry,
     source = GRL_MEDIA_PLUGIN (sources_iter->data);
     id = grl_media_plugin_get_id (source);
     if (!strcmp (plugin_id, id)) {
-      grl_plugin_registry_unregister_source (registry, source);
+      grl_plugin_registry_unregister_source (registry, source, NULL);
     }
   }
   g_list_free (sources);
diff --git a/src/grl-plugin-registry.h b/src/grl-plugin-registry.h
index a3e7c68..c1b5f81 100644
--- a/src/grl-plugin-registry.h
+++ b/src/grl-plugin-registry.h
@@ -207,10 +207,11 @@ gboolean grl_plugin_registry_load_all (GrlPluginRegistry *registry);
 gboolean grl_plugin_registry_register_source (GrlPluginRegistry *registry,
                                               const GrlPluginInfo *plugin,
                                               GrlMediaPlugin *source,
-					      GError **error);
+                                              GError **error);
 
-void grl_plugin_registry_unregister_source (GrlPluginRegistry *registry,
-                                            GrlMediaPlugin *source);
+gboolean grl_plugin_registry_unregister_source (GrlPluginRegistry *registry,
+                                                GrlMediaPlugin *source,
+                                                GError **error);
 
 GrlMediaPlugin *grl_plugin_registry_lookup_source (GrlPluginRegistry *registry,
                                                    const gchar *source_id);