[libgdata/libgdata-0-6] picasaweb: Fix a memory leak in GDataPicasaWebService



commit 895c0483115ffcd675d8f7394bb31ade80eecffa
Author: Philip Withnall <philip tecnocode co uk>
Date:   Fri Dec 10 12:12:17 2010 +0000

    picasaweb: Fix a memory leak in GDataPicasaWebService

 gdata/services/picasaweb/gdata-picasaweb-service.c |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)
---
diff --git a/gdata/services/picasaweb/gdata-picasaweb-service.c b/gdata/services/picasaweb/gdata-picasaweb-service.c
index f48913f..cbc4c51 100644
--- a/gdata/services/picasaweb/gdata-picasaweb-service.c
+++ b/gdata/services/picasaweb/gdata-picasaweb-service.c
@@ -496,18 +496,20 @@ upload_file_async_cb (GOutputStream *output_stream, GAsyncResult *result, Upload
 	if (error == NULL)
 		file = parse_spliced_stream (output_stream, &error);
 
-	if (error == NULL && file != NULL)
+	if (error == NULL && file != NULL) {
 		async_result = g_simple_async_result_new (G_OBJECT (data->service), (GAsyncReadyCallback) data->callback,
-							  data->user_data, gdata_picasaweb_service_upload_file_async);
-	else
+		                                          data->user_data, gdata_picasaweb_service_upload_file_async);
+	} else {
 		async_result = g_simple_async_result_new_from_error (G_OBJECT (data->service), (GAsyncReadyCallback) data->callback,
-								     data->user_data, error);
+		                                                     data->user_data, error);
+	}
 
 	g_simple_async_result_set_op_res_gpointer (async_result, file, NULL);
 
 	g_simple_async_result_complete (async_result);
 
 	upload_file_async_data_free (data);
+	g_object_unref (async_result);
 }
 
 /**



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]