GNOME.org
 

[libgdata] picasaweb: Remove GDataPicasaWebFile:client

commit fadf3de794738340162b53c0390f4254614b7ebc
Author: Philip Withnall <philip tecnocode co uk>
Date:   Thu Dec 2 18:19:45 2010 +0000

    picasaweb: Remove GDataPicasaWebFile:client
    
    The service no longer deals with client information (see
    http://code.google.com/apis/picasaweb/docs/2.0/releasenotes.html). The
    following API has been removed:
     â?¢ GDataPicasaWebFile:client
     â?¢ gdata_picasaweb_file_get_client()
     â?¢ gdata_picasaweb_file_set_client()

 docs/reference/gdata-sections.txt               |    2 -
 gdata/gdata.symbols                             |    2 -
 gdata/services/picasaweb/gdata-picasaweb-file.c |   67 -----------------------
 gdata/services/picasaweb/gdata-picasaweb-file.h |    2 -
 gdata/tests/picasaweb.c                         |    3 -
 5 files changed, 0 insertions(+), 76 deletions(-)
---
diff --git a/docs/reference/gdata-sections.txt b/docs/reference/gdata-sections.txt
index ac77214..89c2080 100644
--- a/docs/reference/gdata-sections.txt
+++ b/docs/reference/gdata-sections.txt
@@ -1479,8 +1479,6 @@ gdata_picasaweb_file_set_album_id
 gdata_picasaweb_file_get_width
 gdata_picasaweb_file_get_height
 gdata_picasaweb_file_get_size
-gdata_picasaweb_file_get_client
-gdata_picasaweb_file_set_client
 gdata_picasaweb_file_get_checksum
 gdata_picasaweb_file_set_checksum
 gdata_picasaweb_file_get_timestamp
diff --git a/gdata/gdata.symbols b/gdata/gdata.symbols
index da10b9f..ec8232d 100644
--- a/gdata/gdata.symbols
+++ b/gdata/gdata.symbols
@@ -555,8 +555,6 @@ gdata_picasaweb_file_set_album_id
 gdata_picasaweb_file_get_width
 gdata_picasaweb_file_get_height
 gdata_picasaweb_file_get_size
-gdata_picasaweb_file_get_client
-gdata_picasaweb_file_set_client
 gdata_picasaweb_file_get_checksum
 gdata_picasaweb_file_set_checksum
 gdata_picasaweb_file_get_timestamp
diff --git a/gdata/services/picasaweb/gdata-picasaweb-file.c b/gdata/services/picasaweb/gdata-picasaweb-file.c
index 673caed..b2081f2 100644
--- a/gdata/services/picasaweb/gdata-picasaweb-file.c
+++ b/gdata/services/picasaweb/gdata-picasaweb-file.c
@@ -114,7 +114,6 @@ struct _GDataPicasaWebFilePrivate {
 	guint width;
 	guint height;
 	gsize size;
-	gchar *client;
 	gchar *checksum;
 	gint64 timestamp; /* in milliseconds! */
 	gboolean is_commenting_enabled;
@@ -138,7 +137,6 @@ enum {
 	PROP_WIDTH,
 	PROP_HEIGHT,
 	PROP_SIZE,
-	PROP_CLIENT,
 	PROP_CHECKSUM,
 	PROP_TIMESTAMP,
 	PROP_IS_COMMENTING_ENABLED,
@@ -238,22 +236,6 @@ gdata_picasaweb_file_class_init (GDataPicasaWebFileClass *klass)
 	                                                      G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));
 
 	/**
-	 * GDataPicasaWebFile:client:
-	 *
-	 * The name of the software which created or last modified the file.
-	 *
-	 * For more information, see the <ulink type="http" url="http://code.google.com/apis/picasaweb/reference.html#gphoto_client";>
-	 * gphoto specification</ulink>.
-	 *
-	 * Since: 0.4.0
-	 **/
-	g_object_class_install_property (gobject_class, PROP_CLIENT,
-	                                 g_param_spec_string ("client",
-	                                                      "Client", "The name of the software which created or last modified the file.",
-	                                                      NULL,
-	                                                      G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));
-
-	/**
 	 * GDataPicasaWebFile:checksum:
 	 *
 	 * A checksum of the file, useful for duplicate detection.
@@ -736,7 +718,6 @@ gdata_picasaweb_file_finalize (GObject *object)
 	g_free (priv->file_id);
 	g_free (priv->version);
 	g_free (priv->album_id);
-	g_free (priv->client);
 	g_free (priv->checksum);
 	g_free (priv->video_status);
 
@@ -774,9 +755,6 @@ gdata_picasaweb_file_get_property (GObject *object, guint property_id, GValue *v
 		case PROP_SIZE:
 			g_value_set_ulong (value, priv->size);
 			break;
-		case PROP_CLIENT:
-			g_value_set_string (value, priv->client);
-			break;
 		case PROP_CHECKSUM:
 			g_value_set_string (value, priv->checksum);
 			break;
@@ -868,9 +846,6 @@ gdata_picasaweb_file_set_property (GObject *object, guint property_id, const GVa
 			/* TODO: do we allow this to change albums? I think that's how pictures are moved. */
 			gdata_picasaweb_file_set_album_id (self, g_value_get_string (value));
 			break;
-		case PROP_CLIENT:
-			gdata_picasaweb_file_set_client (self, g_value_get_string (value));
-			break;
 		case PROP_CHECKSUM:
 			gdata_picasaweb_file_set_checksum (self, g_value_get_string (value));
 			break;
@@ -931,7 +906,6 @@ parse_xml (GDataParsable *parsable, xmlDoc *doc, xmlNode *node, gpointer user_da
 		if (gdata_parser_string_from_element (node, "videostatus", P_NO_DUPES, &(self->priv->video_status), &success, error) == TRUE ||
 		    gdata_parser_string_from_element (node, "imageVersion", P_NONE, &(self->priv->version), &success, error) == TRUE ||
 		    gdata_parser_string_from_element (node, "albumid", P_NONE, &(self->priv->album_id), &success, error) == TRUE ||
-		    gdata_parser_string_from_element (node, "client", P_NONE, &(self->priv->client), &success, error) == TRUE ||
 		    gdata_parser_string_from_element (node, "checksum", P_NONE, &(self->priv->checksum), &success, error) == TRUE ||
 		    gdata_parser_string_from_element (node, "id", P_REQUIRED | P_NON_EMPTY | P_NO_DUPES,
 		                                      &(self->priv->file_id), &success, error) == TRUE) {
@@ -1020,9 +994,6 @@ get_xml (GDataParsable *parsable, GString *xml_string)
 	if (priv->album_id != NULL)
 		gdata_parser_string_append_escaped (xml_string, "<gphoto:albumid>", priv->album_id, "</gphoto:albumid>");
 
-	if (priv->client != NULL)
-		gdata_parser_string_append_escaped (xml_string, "<gphoto:client>", priv->client, "</gphoto:client>");
-
 	if (priv->checksum != NULL)
 		gdata_parser_string_append_escaped (xml_string, "<gphoto:checksum>", priv->checksum, "</gphoto:checksum>");
 
@@ -1293,44 +1264,6 @@ gdata_picasaweb_file_get_size (GDataPicasaWebFile *self)
 }
 
 /**
- * gdata_picasaweb_file_get_client:
- * @self: a #GDataPicasaWebFile
- *
- * Gets the #GDataPicasaWebFile:client property.
- *
- * Return value: the name of the software which created the photo, or %NULL
- *
- * Since: 0.4.0
- **/
-const gchar *
-gdata_picasaweb_file_get_client (GDataPicasaWebFile *self)
-{
-	g_return_val_if_fail (GDATA_IS_PICASAWEB_FILE (self), NULL);
-	return self->priv->client;
-}
-
-/**
- * gdata_picasaweb_file_set_client:
- * @self: a #GDataPicasaWebFile
- * @client: (allow-none): the name of the software which created or modified the photo, or %NULL
- *
- * Sets the #GDataPicasaWebFile:client property to @client.
- *
- * Set @client to %NULL to unset the property.
- *
- * Since: 0.4.0
- **/
-void
-gdata_picasaweb_file_set_client (GDataPicasaWebFile *self, const gchar *client)
-{
-	g_return_if_fail (GDATA_IS_PICASAWEB_FILE (self));
-
-	g_free (self->priv->client);
-	self->priv->client = g_strdup (client);
-	g_object_notify (G_OBJECT (self), "client");
-}
-
-/**
  * gdata_picasaweb_file_get_checksum:
  * @self: a #GDataPicasaWebFile
  *
diff --git a/gdata/services/picasaweb/gdata-picasaweb-file.h b/gdata/services/picasaweb/gdata-picasaweb-file.h
index 764b219..ccc5512 100644
--- a/gdata/services/picasaweb/gdata-picasaweb-file.h
+++ b/gdata/services/picasaweb/gdata-picasaweb-file.h
@@ -113,8 +113,6 @@ void gdata_picasaweb_file_set_album_id (GDataPicasaWebFile *self, const gchar *a
 guint gdata_picasaweb_file_get_width (GDataPicasaWebFile *self) G_GNUC_PURE;
 guint gdata_picasaweb_file_get_height (GDataPicasaWebFile *self) G_GNUC_PURE;
 gsize gdata_picasaweb_file_get_size (GDataPicasaWebFile *self) G_GNUC_PURE;
-const gchar *gdata_picasaweb_file_get_client (GDataPicasaWebFile *self) G_GNUC_PURE;
-void gdata_picasaweb_file_set_client (GDataPicasaWebFile *self, const gchar *client);
 const gchar *gdata_picasaweb_file_get_checksum (GDataPicasaWebFile *self) G_GNUC_PURE;
 void gdata_picasaweb_file_set_checksum (GDataPicasaWebFile *self, const gchar *checksum);
 gint64 gdata_picasaweb_file_get_timestamp (GDataPicasaWebFile *self);
diff --git a/gdata/tests/picasaweb.c b/gdata/tests/picasaweb.c
index 67029c6..e1c0eda 100644
--- a/gdata/tests/picasaweb.c
+++ b/gdata/tests/picasaweb.c
@@ -758,7 +758,6 @@ test_photo (gconstpointer service)
 	g_assert_cmpuint (gdata_picasaweb_file_get_width (photo), ==, 2576);
 	g_assert_cmpuint (gdata_picasaweb_file_get_height (photo), ==, 1932);
 	g_assert_cmpuint (gdata_picasaweb_file_get_size (photo), ==, 1124730);
-	/* TODO: file wasn't uploaded with client assigned; g_assert_cmpstr (gdata_picasaweb_file_get_client (photo), ==, ??); */
 	/* TODO: file wasn't uploaded with checksum assigned; g_assert_cmpstr (gdata_picasaweb_file_get_checksum (photo), ==, ??); */
 	g_assert_cmpint (gdata_picasaweb_file_get_timestamp (photo), ==, 1228588330000);
 	g_assert_cmpstr (gdata_picasaweb_file_get_video_status (photo), ==, NULL);
@@ -1533,7 +1532,6 @@ test_file_escaping (void)
 
 	/* Set other properties */
 	gdata_picasaweb_file_set_album_id (file, "http://foo.com?foo&bar";);
-	gdata_picasaweb_file_set_client (file, "GIMP & Co.");
 	gdata_picasaweb_file_set_checksum (file, "<checksum>");
 	gdata_picasaweb_file_set_tags (file, tags);
 	gdata_picasaweb_file_set_caption (file, "Caption & stuff.");
@@ -1553,7 +1551,6 @@ test_file_escaping (void)
 				"<gphoto:version>&lt;version&gt;</gphoto:version>"
 				"<gphoto:position>0</gphoto:position>"
 				"<gphoto:albumid>http://foo.com?foo&amp;bar</gphoto:albumid>"
-				"<gphoto:client>GIMP &amp; Co.</gphoto:client>"
 				"<gphoto:checksum>&lt;checksum&gt;</gphoto:checksum>"
 				"<gphoto:commentingEnabled>true</gphoto:commentingEnabled>"
 				"<media:group>"
[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]