[glib] Bug 628324 – Invalid reads in gdbus-export test



commit 52348e15874869cb02052253847358361f10ec7f
Author: David Zeuthen <davidz redhat com>
Date:   Mon Aug 30 13:45:46 2010 -0400

    Bug 628324 â?? Invalid reads in gdbus-export test
    
    Looks like we forgot to ref the returned GVariant in
    g_dbus_proxy_call_finish().
    
    It's a good question why code using g_dbus_proxy_call() and
    g_dbus_proxy_call_finish() worked in the first place - probably the
    answer is that no-one really used these APIs.
    
    Signed-off-by: David Zeuthen <davidz redhat com>

 gio/gdbusproxy.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/gio/gdbusproxy.c b/gio/gdbusproxy.c
index 17e6730..2e7137d 100644
--- a/gio/gdbusproxy.c
+++ b/gio/gdbusproxy.c
@@ -2372,7 +2372,7 @@ g_dbus_proxy_call_finish (GDBusProxy    *proxy,
   if (g_simple_async_result_propagate_error (simple, error))
     goto out;
 
-  value = g_simple_async_result_get_op_res_gpointer (simple);
+  value = g_variant_ref (g_simple_async_result_get_op_res_gpointer (simple));
   method_name = g_object_get_data (G_OBJECT (simple), "-gdbus-proxy-method-name");
 
  out:



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]