[gnumeric] xml: plug leak.
- From: Morten Welinder <mortenw src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnumeric] xml: plug leak.
- Date: Mon, 23 Aug 2010 20:09:23 +0000 (UTC)
commit f6e5ac2bf30f4f6c9ae8ceea11cd3c2639ed62a6
Author: Morten Welinder <terra gnome org>
Date: Mon Aug 23 16:06:52 2010 -0400
xml: plug leak.
ChangeLog | 1 +
src/xml-sax-read.c | 12 +++++++-----
2 files changed, 8 insertions(+), 5 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index 6b9768f..6d8c0ce 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,6 +1,7 @@
2010-08-23 Morten Welinder <terra gnome org>
* src/xml-sax-read.c (xml_sax_colrow): Simplify and plug leak.
+ (xml_sax_finish_parse_wb_attr): Plug leak.
2010-08-20 Andreas J. Guelzow <aguelzow pyrshep ca>
diff --git a/src/xml-sax-read.c b/src/xml-sax-read.c
index 778186d..ed37a5a 100644
--- a/src/xml-sax-read.c
+++ b/src/xml-sax-read.c
@@ -626,11 +626,13 @@ xml_sax_finish_parse_wb_attr (GsfXMLIn *xin, G_GNUC_UNUSED GsfXMLBlob *blob)
{
XMLSaxParseState *state = (XMLSaxParseState *)xin->user_state;
- g_return_if_fail (state->attribute.name != NULL);
- g_return_if_fail (state->attribute.value != NULL);
-
- wb_view_set_attribute (state->wb_view,
- state->attribute.name, state->attribute.value);
+ if (state->attribute.name && state->attribute.value) {
+ wb_view_set_attribute (state->wb_view,
+ state->attribute.name,
+ state->attribute.value);
+ } else {
+ xml_sax_barf (G_STRFUNC, "workbook view attributes complete");
+ }
g_free (state->attribute.value); state->attribute.value = NULL;
g_free (state->attribute.name); state->attribute.name = NULL;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]