[libgsf] Fix one "Result of operation is garbage or undefined" detected by clang



commit 40c3dbf06c1bc9f4b39bc324eede26b81e1357fd
Author: J.H.M. Dassen (Ray) <jdassen debian org>
Date:   Thu Aug 19 22:26:19 2010 +0200

    Fix one "Result of operation is garbage or undefined" detected by clang

 gsf/gsf-msole-utils.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/gsf/gsf-msole-utils.c b/gsf/gsf-msole-utils.c
index 965b31c..0ea54f6 100644
--- a/gsf/gsf-msole-utils.c
+++ b/gsf/gsf-msole-utils.c
@@ -1528,6 +1528,7 @@ msole_metadata_write_section (WritePropState *state, gboolean user)
 
 	/* 2) props */
 	for (; ptr != NULL && i < count ; ptr = ptr->next, i++) {
+		offsets[i].offset = gsf_output_tell (state->out);
 		prop = ptr->data;
 		name = gsf_doc_prop_get_name (prop);
 		if (user) {
@@ -1546,7 +1547,6 @@ msole_metadata_write_section (WritePropState *state, gboolean user)
 			offsets[i].id = map->id;
 		}
 
-		offsets[i].offset = gsf_output_tell (state->out);
 		msole_metadata_write_prop (state, name,
 			gsf_doc_prop_get_val  (prop), FALSE);
 		if (gsf_doc_prop_get_link (prop)) {



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]