[rhythmbox] oops, don't need to unref after rhythmdb_entry_lookup_by_location



commit 1e8bd70707baac1058505c2eaa9ab1f2cdbc612a
Author: Jonathan Matthew <jonathan d14n org>
Date:   Sun Aug 15 08:43:10 2010 +1000

    oops, don't need to unref after rhythmdb_entry_lookup_by_location

 plugins/mpris/rb-mpris-plugin.c |    2 --
 shell/rb-shell.c                |    4 ----
 2 files changed, 0 insertions(+), 6 deletions(-)
---
diff --git a/plugins/mpris/rb-mpris-plugin.c b/plugins/mpris/rb-mpris-plugin.c
index 2121873..a44f81b 100644
--- a/plugins/mpris/rb-mpris-plugin.c
+++ b/plugins/mpris/rb-mpris-plugin.c
@@ -515,11 +515,9 @@ handle_player_method_call (GDBusConnection *connection,
 			/* client got the wrong entry, ignore it */
 			g_dbus_method_invocation_return_value (invocation, NULL);
 			rhythmdb_entry_unref (playing_entry);
-			rhythmdb_entry_unref (client_entry);
 			return;
 		}
 		rhythmdb_entry_unref (playing_entry);
-		rhythmdb_entry_unref (client_entry);
 
 		ret = rb_shell_player_set_playing_time (plugin->player, position / G_USEC_PER_SEC, &error);
 		handle_result (invocation, ret, error);
diff --git a/shell/rb-shell.c b/shell/rb-shell.c
index 2d7f3a9..7438d94 100644
--- a/shell/rb-shell.c
+++ b/shell/rb-shell.c
@@ -3215,7 +3215,6 @@ shell_load_uri_done (RBSource *source, const char *uri, RBShell *shell)
 	entry = rhythmdb_entry_lookup_by_location (shell->priv->db, uri);
 	if (entry) {
 		rb_shell_play_entry (shell, entry);
-		rhythmdb_entry_unref (entry);
 	} else {
 		rb_debug ("unable to find entry for uri %s", uri);
 	}
@@ -3361,7 +3360,6 @@ rb_shell_load_uri (RBShell *shell,
 
 		if (entry) {
 			rb_shell_play_entry (shell, entry);
-			rhythmdb_entry_unref (entry);
 		}
 	}
 
@@ -3484,8 +3482,6 @@ rb_shell_add_to_queue (RBShell *shell,
 				     uri);
 			return FALSE;
 		}
-	} else {
-		rhythmdb_entry_unref (entry);
 	}
 	rb_static_playlist_source_add_location (RB_STATIC_PLAYLIST_SOURCE (shell->priv->queue_source),
 						uri, -1);



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]