[dia] [warningectomy] no more 'width_range' defined but not used



commit e1827d883d29d1edeee4774ab4c6a5f35048fc47
Author: Hans Breuer <hans breuer org>
Date:   Fri Aug 6 14:09:59 2010 +0200

    [warningectomy] no more 'width_range' defined but not used
    
    Following the pattern from lib/properties.h to only have
    PropNumData static if it has to be (on win32).

 lib/element.c |    6 ++++++
 lib/element.h |    7 +++++++
 2 files changed, 13 insertions(+), 0 deletions(-)
---
diff --git a/lib/element.c b/lib/element.c
index de1bce4..76cd115 100644
--- a/lib/element.c
+++ b/lib/element.c
@@ -32,6 +32,12 @@
 #include "element.h"
 #include "message.h"
 
+#ifdef G_OS_WIN32
+/* defined in header */
+#else
+PropNumData width_range = { -G_MAXFLOAT, G_MAXFLOAT, 0.1};
+#endif
+
 /** Update the boundingbox information for this element.
  * @param An object to update bounding box on.
  */
diff --git a/lib/element.h b/lib/element.h
index cab1714..48a0e41 100644
--- a/lib/element.h
+++ b/lib/element.h
@@ -63,7 +63,14 @@ void element_save(Element *elem, ObjectNode obj_node);
 void element_load(Element *elem, ObjectNode obj_node);
 
 /* base property stuff ... */
+#ifdef G_OS_WIN32
+/* see lib/properties.h for the reason */
 static PropNumData width_range = { -G_MAXFLOAT, G_MAXFLOAT, 0.1};
+#else
+/* use extern on Linux/gcc to avoid 
+ * warning: 'width_range' defined but not used */
+extern PropNumData width_range;
+#endif
 
 #define ELEMENT_COMMON_PROPERTIES \
   OBJECT_COMMON_PROPERTIES, \



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]