[banshee] [Services] Refactoring of SaveTrackMetadataJob's commands creation

[Andrés Aragoneses <aaragoneses src gnome org>]

commit 0379339a245c6dc970c9202a81394b1bbca2e818
Author: Andrés G. Aragoneses <knocte gmail com>
Date:   Fri Aug 6 02:26:13 2010 +0200

    [Services] Refactoring of SaveTrackMetadataJob's commands creation
    
    CountCommand and SelectCommand have actually the same WHERE clause so
    reusing it here is better to keep DRY. Also adding small finding about
    the WHERE in a FIXME.
    
    Signed-off-by: Alexander Kojevnikov <alexander kojevnikov com>

 .../Banshee.Metadata/SaveTrackMetadataJob.cs       |   16 ++++++++--------
 1 files changed, 8 insertions(+), 8 deletions(-)
---
diff --git a/src/Core/Banshee.Services/Banshee.Metadata/SaveTrackMetadataJob.cs b/src/Core/Banshee.Services/Banshee.Metadata/SaveTrackMetadataJob.cs
index 0f5ed1b..77f993a 100644
--- a/src/Core/Banshee.Services/Banshee.Metadata/SaveTrackMetadataJob.cs
+++ b/src/Core/Banshee.Services/Banshee.Metadata/SaveTrackMetadataJob.cs
@@ -59,15 +59,15 @@ namespace Banshee.Metadata
 
             string range = String.Join (",", db_ids);
 
-            CountCommand = new HyenaSqliteCommand (String.Format (
-                @"SELECT COUNT(*) FROM CoreTracks
-                  WHERE DateUpdatedStamp > LastSyncedStamp
-                  AND PrimarySourceID IN ({0})", range)
-            );
-
-            SelectCommand = DatabaseTrackInfo.Provider.CreateFetchCommand (String.Format (
-                "DateUpdatedStamp > LastSyncedStamp AND PrimarySourceID IN ({0})", range)
-            );
+            //FIXME: should we add the case in which LastSyncedStamp IS NULL?
+            string condition = String.Format (
+                @"DateUpdatedStamp > LastSyncedStamp
+                  AND PrimarySourceID IN ({0})", range);
+
+            CountCommand = new HyenaSqliteCommand (
+                "SELECT COUNT(*) FROM CoreTracks WHERE " + condition);
+
+            SelectCommand = DatabaseTrackInfo.Provider.CreateFetchCommand (condition);
         }
 
         public bool WriteMetadataEnabled { get; set; }