[gnome-color-manager] trivial: add proper enums for the graph type, not magic values



commit 1d7266c619fe739f75df54dd92eb7be93a1f8f8e
Author: Richard Hughes <richard hughsie com>
Date:   Thu Aug 5 13:41:50 2010 +0100

    trivial: add proper enums for the graph type, not magic values

 src/gcm-viewer.c |   19 ++++++++++++++-----
 1 files changed, 14 insertions(+), 5 deletions(-)
---
diff --git a/src/gcm-viewer.c b/src/gcm-viewer.c
index 2b70b3a..5774bb1 100644
--- a/src/gcm-viewer.c
+++ b/src/gcm-viewer.c
@@ -52,6 +52,15 @@ typedef struct {
 	GSettings	*settings;
 } GcmViewerPrivate;
 
+typedef enum {
+	GCM_VIEWER_NONE,
+	GCM_VIEWER_CIE_1931,
+	GCM_VIEWER_TRC,
+	GCM_VIEWER_VCGT,
+	GCM_VIEWER_PREVIEW_INPUT,
+	GCM_VIEWER_PREVIEW_OUTPUT
+} GcmViewerGraphType;
+
 enum {
 	GCM_PROFILES_COLUMN_ID,
 	GCM_PROFILES_COLUMN_SORT,
@@ -928,23 +937,23 @@ gcm_viewer_graph_combo_changed_cb (GtkWidget *widget, GcmViewerPrivate *viewer)
 
 	/* hide or show the correct graphs */
 	widget = GTK_WIDGET (gtk_builder_get_object (viewer->builder, "vbox_cie_axis"));
-	gtk_widget_set_visible (widget, active == 1);
+	gtk_widget_set_visible (widget, active == GCM_VIEWER_CIE_1931);
 
 	/* hide or show the correct graphs */
 	widget = GTK_WIDGET (gtk_builder_get_object (viewer->builder, "vbox_trc_axis"));
-	gtk_widget_set_visible (widget, active == 2);
+	gtk_widget_set_visible (widget, active == GCM_VIEWER_TRC);
 
 	/* hide or show the correct graphs */
 	widget = GTK_WIDGET (gtk_builder_get_object (viewer->builder, "vbox_vcgt_axis"));
-	gtk_widget_set_visible (widget, active == 3);
+	gtk_widget_set_visible (widget, active == GCM_VIEWER_VCGT);
 
 	/* hide or show the correct graphs */
 	widget = GTK_WIDGET (gtk_builder_get_object (viewer->builder, "vbox_preview_input"));
-	gtk_widget_set_visible (widget, active == 4);
+	gtk_widget_set_visible (widget, active == GCM_VIEWER_PREVIEW_INPUT);
 
 	/* hide or show the correct graphs */
 	widget = GTK_WIDGET (gtk_builder_get_object (viewer->builder, "vbox_preview_output"));
-	gtk_widget_set_visible (widget, active == 5);
+	gtk_widget_set_visible (widget, active == GCM_VIEWER_PREVIEW_OUTPUT);
 
 	/* save to GSettings */
 	g_settings_set_enum (viewer->settings, GCM_SETTINGS_PROFILE_GRAPH_TYPE, active);



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]