[at-spi2-atk] Prevent crash if calling Embed returns something unexpected
- From: Mike Gorse <mgorse src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [at-spi2-atk] Prevent crash if calling Embed returns something unexpected
- Date: Thu, 29 Apr 2010 21:46:51 +0000 (UTC)
commit dd8aee742016d5cc0878098301f336d8420ff228
Author: Mike Gorse <mgorse novell com>
Date: Thu Apr 29 17:46:36 2010 -0400
Prevent crash if calling Embed returns something unexpected
atk-adaptor/bridge.c | 18 +++++-------------
1 files changed, 5 insertions(+), 13 deletions(-)
---
diff --git a/atk-adaptor/bridge.c b/atk-adaptor/bridge.c
index cbced24..bd20727 100644
--- a/atk-adaptor/bridge.c
+++ b/atk-adaptor/bridge.c
@@ -210,24 +210,16 @@ register_application (SpiBridge * app)
DBusMessageIter iter, iter_struct;
gchar *app_name, *obj_path;
- dbus_message_iter_init (reply, &iter);
- dbus_message_iter_recurse (&iter, &iter_struct);
- if (!(dbus_message_iter_get_arg_type (&iter_struct) == DBUS_TYPE_STRING))
+ if (strcmp (dbus_message_get_signature (reply), "(so)") != 0)
{
g_warning ("AT-SPI: Could not obtain desktop path or name\n");
return FALSE;
}
+
+ dbus_message_iter_init (reply, &iter);
+ dbus_message_iter_recurse (&iter, &iter_struct);
dbus_message_iter_get_basic (&iter_struct, &app_name);
- if (!dbus_message_iter_next (&iter_struct))
- {
- g_warning ("AT-SPI: Could not obtain desktop name");
- return FALSE;
- }
- if (!(dbus_message_iter_get_arg_type (&iter_struct) == DBUS_TYPE_OBJECT_PATH))
- {
- g_warning ("AT-SPI: Could not obtain desktop path");
- return FALSE;
- }
+ dbus_message_iter_next (&iter_struct);
dbus_message_iter_get_basic (&iter_struct, &obj_path);
app->desktop_name = g_strdup (app_name);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]