[xmlsec] minor fixes to xmlsec-nss (xmlsec bug #118630) - bumping nss min version to 3.9



commit f7e8b94d70f8a3a388663e546cc3136c92b92603
Author: Aleksey Sanin <aleksey aleksey com>
Date:   Sun Apr 25 20:19:16 2010 -0700

    minor fixes to xmlsec-nss (xmlsec bug #118630) - bumping nss min version to 3.9

 TODO           |   46 +++++++++++++++++++++++++++++++++++++++++-----
 configure.in   |    4 ++--
 src/nss/README |   11 +----------
 src/nss/x509.c |    6 +-----
 4 files changed, 45 insertions(+), 22 deletions(-)
---
diff --git a/TODO b/TODO
index 280c983..1e9a307 100644
--- a/TODO
+++ b/TODO
@@ -1,6 +1,42 @@
-- Unify password callback (one of parameters: filename)
-- get key usage from certs
-- extend keys manager to return more info when key is found or not found
-(what cheks were performed, etc.)
+General
+-------------------------------------------------
+
+* Unify password callback (one of parameters: filename)
+* Get key usage from certs
+* Extend keys manager to return more info when key is found or not found 
+  (what cheks were performed, etc.)
+
+
+Tests status
+-------------------------------------------------
+
+* xmlsec-nss (April 25, 2010)
+
+** Skipped tests (missing transforms: RIPEMD160, SHA224, RSA/OAEP, GOST)
+
+aleksey-xmldsig-01/enveloping-ripemd160-hmac-ripemd160
+aleksey-xmldsig-01/enveloping-ripemd160-hmac-ripemd160-64
+aleksey-xmldsig-01/enveloping-sha224-hmac-sha224
+aleksey-xmldsig-01/enveloping-sha224-hmac-sha224-64
+aleksey-xmldsig-01/enveloping-ripemd160-rsa-ripemd160
+aleksey-xmldsig-01/enveloping-sha224-rsa-sha224
+aleksey-xmldsig-01/enveloped-gost
+merlin-xmlenc-five/encsig-ripemd160-hmac-ripemd160-kw-tripledes
+merlin-xmlenc-five/encrypt-data-tripledes-cbc-rsa-oaep-mgf1p
+01-phaos-xmlenc-3/enc-element-3des-kt-rsa_oaep_sha1
+01-phaos-xmlenc-3/enc-element-aes128-kt-rsa_oaep_sha1
+01-phaos-xmlenc-3/enc-element-aes192-kt-rsa_oaep_sha1
+01-phaos-xmlenc-3/enc-text-aes256-kt-rsa_oaep_sha1
+
+** Failed tests
+
+aleksey-xmldsig-01/x509data-test
+aleksey-xmldsig-01/x509data-sn-test
+merlin-xmldsig-twenty-three/signature-x509-is
+merlin-xmldsig-twenty-three/signature-x509-ski
+phaos-xmldsig-three/signature-rsa-manifest-x509-data-ski
+merlin-xmldsig-twenty-three/signature-x509-crt-crl
+
+* xmlsec-mscrypto (April 25, 2010)
+
 
-    
\ No newline at end of file
diff --git a/configure.in b/configure.in
index 18c5b4d..83bdd3c 100644
--- a/configure.in
+++ b/configure.in
@@ -546,8 +546,8 @@ dnl ==========================================================================
     
 XMLSEC_NO_NSS="1"
 MOZILLA_MIN_VERSION="1.4"
-NSS_MIN_VERSION="3.8"
-NSPR_MIN_VERSION="4.3"
+NSS_MIN_VERSION="3.9"
+NSPR_MIN_VERSION="4.4.1"
 NSS_CFLAGS=""
 NSS_LIBS=""
 NSS_LIBS_LIST="-lnss3 -lsmime3"
diff --git a/src/nss/README b/src/nss/README
index cce889b..65dd5bd 100644
--- a/src/nss/README
+++ b/src/nss/README
@@ -63,16 +63,7 @@ that is missing from xmlsec-nss.
 
 4) There are 2 fixes in NSS that will be rolled into the next release (3.9).
 They are:
-    - http://bugzilla.mozilla.org/show_bug.cgi?id=208194
-    Once available, need to change src/nss/x509.c. Replace
-        PR_AtomicIncrement(&(crlSrc->referenceCount));
-    with
-        SEC_DupCrl(crlSrc);
-    (there is a comment there that already has the correct line)
-
-    - http://bugzilla.mozilla.org/show_bug.cgi?id=211384
-    No changes required. The "NSS_Shutdown failed" in some of the
-    current tests will go away
+
 
 xmlsec bug: http://bugzilla.gnome.org/show_bug.cgi?id=118630
 
diff --git a/src/nss/x509.c b/src/nss/x509.c
index 9b0a78d..e05edc0 100644
--- a/src/nss/x509.c
+++ b/src/nss/x509.c
@@ -617,11 +617,7 @@ xmlSecNssKeyDataX509Duplicate(xmlSecKeyDataPtr dst, xmlSecKeyDataPtr src) {
             return(-1);
         }
 
-        /* TBD: SEC_DupCrl isn't exported by NSS yet */
-        /*crlDst = SEC_DupCrl(crlSrc);*/
-        crlDst = crlSrc;
-        PR_AtomicIncrement(&(crlSrc->referenceCount));
-
+        crlDst = SEC_DupCrl(crlSrc);
         if(crlDst == NULL) {
             xmlSecError(XMLSEC_ERRORS_HERE,
                         xmlSecErrorsSafeString(xmlSecKeyDataGetName(dst)),



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]