[evolution-rss] compile warnings cleanup



commit 8b4a6b207aa150055cae0476ce319168106874cc
Author: Lucian Langa <lucilanga gnome org>
Date:   Thu Apr 22 08:27:08 2010 +0300

    compile warnings cleanup

 TODO                     |    1 +
 src/parser.c             |   14 +++++++++-----
 src/rss-config-factory.c |   38 --------------------------------------
 src/rss.c                |   18 +++++++++++++-----
 4 files changed, 23 insertions(+), 48 deletions(-)
---
diff --git a/TODO b/TODO
index 57e790c..a263459 100644
--- a/TODO
+++ b/TODO
@@ -39,3 +39,4 @@
 	* option to download enclosures (limit to certain size)
 	* split rss feed
 	* possibly completely disable messagefiltering at setup_feed
+	* after deletion properties list is not updated, or not in sync
diff --git a/src/parser.c b/src/parser.c
index 121ed8c..0199a8b 100644
--- a/src/parser.c
+++ b/src/parser.c
@@ -864,6 +864,7 @@ parse_channel_line(xmlNode *top, gchar *feed_name, char *main_date)
 	char *sp = NULL;
 	char *d, *link = NULL;
 	char *comments = NULL;
+	char *p, *q1, *q2, *q3;
 	gchar *feed = NULL;
 	gchar *encl, *tmp, *id;
 	gchar *qsafe, *tcat;
@@ -891,14 +892,14 @@ parse_channel_line(xmlNode *top, gchar *feed_name, char *main_date)
 		return NULL;
 	}
 
-	char *p = g_strdup(layer_find (top, "title", "Untitled article"));
+	p = g_strdup(layer_find (top, "title", "Untitled article"));
 	//firstly try to parse as an ATOM author
 	//process person construct
-	char *q1 = g_strdup(
+	q1 = g_strdup(
 			layer_find_innerhtml (top, "author", "name", NULL));
-	char *q2 = g_strdup(
+	q2 = g_strdup(
 			layer_find_innerhtml (top, "author", "uri", NULL));
-	char *q3 = g_strdup(
+	q3 = g_strdup(
 			layer_find_innerhtml (top, "author", "email", NULL));
 	if (q1) {
 		q1 = g_strdelimit(q1, "><", ' ');
@@ -1065,6 +1066,9 @@ parse_channel_line(xmlNode *top, gchar *feed_name, char *main_date)
 }
 
 void
+refresh_mail_folder(CamelFolder *mail_folder);
+
+void
 refresh_mail_folder(CamelFolder *mail_folder)
 {
 	mail_refresh_folder(mail_folder, NULL, NULL);
@@ -1089,7 +1093,7 @@ update_channel(RDF *r)
 	gchar *buf, *safes, *feed_dir, *feed_name;
 	gchar *uid, *msg;
 	gboolean freeze = FALSE;
-	CamelFolder *mail_folder;
+	CamelFolder *mail_folder = NULL;
 
 	safes = encode_rfc2047(chn_name);
 	sender = g_strdup_printf("%s <%s>", safes, chn_name);
diff --git a/src/rss-config-factory.c b/src/rss-config-factory.c
index cdc2cd3..c9dc5eb 100644
--- a/src/rss-config-factory.c
+++ b/src/rss-config-factory.c
@@ -1635,12 +1635,9 @@ import_opml(gchar *file)
 	gchar *url = NULL;
 	xmlChar *name = NULL;
 	guint total = 0;
-	guint current = 0;
 	guint type = 0; //file type
-	gchar *what = NULL;
 	gchar *msg, *tmp, *maintitle = NULL;
 	GtkWidget *import_label;
-	float fr;
 
 	xmlNode *src = (xmlNode *)xmlParseFile (file);
 	xmlNode *doc = NULL;
@@ -2185,41 +2182,6 @@ import_cb (GtkWidget *widget, gpointer data)
 	return;
 }
 
-static void
-get_folder_info (
-	CamelStore *store, CamelFolderInfo *info, CamelException *ex)
-{
-while (info) {
-		CamelFolder *fold;
-		gchar **path, *fpath;
-		gint i=0;
-
-	if (info->child) {
-		get_folder_info(store, info->child, ex);
-		if (camel_exception_is_set (ex))
-			return;
-	}
-
-	if (!(fold = camel_store_get_folder (store, info->full_name, 0, ex)))
-		return;
-
-//g_print("fold:%s\n", fold->full_name);
-	fpath = extract_main_folder(fold->full_name);
-	g_print("fpath:%s\n", fpath);
-
-	path = g_strsplit(fpath, G_DIR_SEPARATOR_S, 0);
-	if (path) {
-		do {
-			g_print("path:%s\n", path[i]);
-		} while (NULL != path[i++]);
-	}
-
-	info = info->next;
-	}
-
-
-}
-
 GList*
 gen_folder_parents(
 	GList *list, GList *flist, gchar *tmp);
diff --git a/src/rss.c b/src/rss.c
index 74751e5..31b2754 100644
--- a/src/rss.c
+++ b/src/rss.c
@@ -446,7 +446,7 @@ update_progress_text(gchar *title)
 	if (!rf->progress_bar)
 		return;
 
-	label = g_object_get_data(rf->progress_bar, "label");
+	label = g_object_get_data((GObject *)rf->progress_bar, "label");
 	if (label) {
 		gtk_label_set_text(
 			GTK_LABEL(label), title);
@@ -460,6 +460,9 @@ update_progress_text(gchar *title)
 }
 
 void
+update_progress_bar(guint current);
+
+void
 update_progress_bar(guint current)
 {
 	gdouble fr;
@@ -469,13 +472,17 @@ update_progress_bar(guint current)
 
 	g_return_if_fail(rf->progress_bar != NULL);
 
-	total = GPOINTER_TO_INT(g_object_get_data(rf->progress_bar, "total"));
+	total = GPOINTER_TO_INT(g_object_get_data(
+				(GObject *)rf->progress_bar,
+				"total"));
 	val = total - current;
 	fr = ((val*100)/total);
 	if (fr < 100)
-		gtk_progress_bar_set_fraction(rf->progress_bar, fr/100);
+		gtk_progress_bar_set_fraction(
+			(GtkProgressBar *)rf->progress_bar, fr/100);
 	what = g_strdup_printf(_("%2.0f%% done"), fr);
-	gtk_progress_bar_set_text(rf->progress_bar, what);
+	gtk_progress_bar_set_text(
+		(GtkProgressBar *)rf->progress_bar, what);
 	g_free(what);
 }
 
@@ -4793,6 +4800,7 @@ out:	if (folder) {
 	}
 	delete_feed_folder_alloc(name);
 	g_free(name);
+	g_print("gidle store redra\n");
 	g_idle_add((GSourceFunc)store_redraw,
 		GTK_TREE_VIEW(rf->treeview));
 	save_gconf_feed();
@@ -5927,7 +5935,7 @@ create_mail(create_feed *CF)
 		g_ptr_array_add(filter_uids, appended_uid);
 		mail_filter_on_demand (mail_folder, filter_uids);
 /*FIXME do not know how to free this
-		g_object_weak_ref((GObject *)filter_uids, free_filter_uids, NULL);*/
+//		g_object_weak_ref((GObject *)filter_uids, free_filter_uids, NULL);*/
 	}
 	//FIXME too lasy to write a separate function
 	if (!rf->import)



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]