[grilo-plugins] [metadata-store] [test] Use float type for ratings



commit 6ff188433311f02b6b5f9e9a06643cd84d788d68
Author: Iago Toral Quiroga <itoral igalia com>
Date:   Tue Apr 13 15:47:21 2010 +0200

    [metadata-store] [test] Use float type for ratings

 src/metadata-store/grl-metadata-store.c |   13 +++----------
 test/main.c                             |    6 +++---
 2 files changed, 6 insertions(+), 13 deletions(-)
---
diff --git a/src/metadata-store/grl-metadata-store.c b/src/metadata-store/grl-metadata-store.c
index b6a01c1..75ca15e 100644
--- a/src/metadata-store/grl-metadata-store.c
+++ b/src/metadata-store/grl-metadata-store.c
@@ -240,7 +240,7 @@ fill_metadata (GrlMedia *media, GList *keys, sqlite3_stmt *stmt)
   GList *iter;
   gint play_count, last_position;
   gdouble rating;
-  gchar *last_played, *rating_str;
+  gchar *last_played;
   gint r;
 
   while ((r = sqlite3_step (stmt)) == SQLITE_BUSY);
@@ -261,9 +261,7 @@ fill_metadata (GrlMedia *media, GList *keys, sqlite3_stmt *stmt)
       break;
     case GRL_METADATA_KEY_RATING:
       rating = sqlite3_column_double (stmt, STORE_RATING);
-      rating_str = g_strdup_printf ("%.2f", rating);
-      grl_media_set_rating (media, rating_str, "5");
-      g_free (rating_str);
+      grl_media_set_rating (media, rating, 5.00);
       break;
     case GRL_METADATA_KEY_LAST_PLAYED:
       last_played = (gchar *) sqlite3_column_text (stmt, STORE_LAST_PLAYED);
@@ -338,12 +336,7 @@ bind_and_exec (sqlite3 *db,
       GrlKeyID key_id = POINTER_TO_GRLKEYID (iter_keys->data);
       switch (key_id) {
       case GRL_METADATA_KEY_RATING:
-	char_value = grl_media_get_rating (media);
-	if (char_value) {
-	  double_value = g_ascii_strtod (char_value, NULL);
-	} else {
-	  double_value = 0;
-	}
+	double_value = grl_media_get_rating (media);
 	sqlite3_bind_double (stmt, count, double_value);
 	break;
       case GRL_METADATA_KEY_PLAY_COUNT:
diff --git a/test/main.c b/test/main.c
index 32de62c..0c57e0b 100644
--- a/test/main.c
+++ b/test/main.c
@@ -331,7 +331,7 @@ main (void)
   if (0) grl_media_source_browse (youtube, NULL, keys, 0, 5, GRL_RESOLVE_IDLE_RELAY , browse_cb, NULL);
   if (0) grl_media_source_browse (youtube, media_from_id ("standard-feeds/most-viewed"), keys, 0, 10, GRL_RESOLVE_FAST_ONLY , browse_cb, NULL);
   if (0) grl_media_source_browse (youtube, media_from_id ("categories/Sports"), keys,  0, 5, GRL_RESOLVE_FAST_ONLY, browse_cb, NULL);
-  if (0) grl_media_source_search (youtube, "igalia", keys, 0, 3, GRL_RESOLVE_FULL | GRL_RESOLVE_FAST_ONLY, browse_cb, NULL);
+  if (1) grl_media_source_search (youtube, "igalia", keys, 0, 5, GRL_RESOLVE_NORMAL, browse_cb, NULL);
   if (0) grl_media_source_search (youtube, "igalia", keys, 1, 10, GRL_RESOLVE_FULL | GRL_RESOLVE_IDLE_RELAY | GRL_RESOLVE_FAST_ONLY, browse_cb, NULL);
   if (0) grl_media_source_metadata (youtube, NULL, keys, 0, metadata_cb, NULL);
   if (0) grl_media_source_metadata (youtube, NULL, keys, GRL_RESOLVE_IDLE_RELAY | GRL_RESOLVE_FAST_ONLY | GRL_RESOLVE_FULL, metadata_cb, NULL);
@@ -375,11 +375,11 @@ main (void)
                          "pop hits");
     grl_metadata_source_resolve (lastfm, keys, media, GRL_RESOLVE_IDLE_RELAY, resolve_cb, NULL);
   }
-  if (1) {
+  if (0) {
     GrlMedia *media = media_from_id ("test-id");
     grl_media_set_source (media, "some-source-id");
     grl_media_set_play_count (media,  68);
-    grl_media_set_rating (media,  "4.5", "5");
+    grl_media_set_rating (media,  4.5, 5.00);
     grl_media_set_last_position (media, 60);
     grl_media_set_last_played (media, "19/11/2009");
     GList *keys_to_write = grl_metadata_key_list_new (GRL_METADATA_KEY_PLAY_COUNT,



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]