[bug-buddy] gnome-breakpad.cc: Do not write beyond allocated strings array in CircBuffer



commit 59d8095b59f6fb6724afe6d3708281d07edddf1d
Author: Tobias Mueller <tobiasmue gnome org>
Date:   Sat Apr 10 20:49:16 2010 +0100

    gnome-breakpad.cc: Do not write beyond allocated strings array in CircBuffer
    
    g_new0 allocated $size elements, just set the last one to NULL.
    Fixes gbo 61503.

 gnome-breakpad/gnome-breakpad.cc |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/gnome-breakpad/gnome-breakpad.cc b/gnome-breakpad/gnome-breakpad.cc
index 7cacc86..d0add88 100644
--- a/gnome-breakpad/gnome-breakpad.cc
+++ b/gnome-breakpad/gnome-breakpad.cc
@@ -112,7 +112,7 @@ circ_buff_new (int size)
 
 	retval = g_new0 (CircBuff, 1);
 	retval->strings = g_new0 (char *, size + 1);
-	retval->strings[size + 1] = NULL;
+	retval->strings[size] = NULL;
 	retval->size = size;
 
 	return retval;



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]