[vte] Add FIXME about potential optimisation
- From: Christian Persch <chpe src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [vte] Add FIXME about potential optimisation
- Date: Sat, 10 Apr 2010 14:39:31 +0000 (UTC)
commit e70fbd240fd230155a5321907bfe6f4fa032586c
Author: Christian Persch <chpe gnome org>
Date: Sat Apr 10 16:27:19 2010 +0200
Add FIXME about potential optimisation
src/vtebg.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
---
diff --git a/src/vtebg.c b/src/vtebg.c
index e5bd7f9..1f8a4f0 100644
--- a/src/vtebg.c
+++ b/src/vtebg.c
@@ -438,6 +438,14 @@ vte_bg_get_surface(VteBg *bg,
return cached;
}
+ /* FIXME: The above only returned a hit when the source *and*
+ * tint and saturation matched. This means that for VTE_BG_SOURCE_FILE,
+ * we will create below *another* #GdkPixbuf for the same source file,
+ * wasting memory. We should instead look up the source pixbuf regardless
+ * of tint and saturation, and just create a new #VteBgCacheItem
+ * with a new surface for it.
+ */
+
item = g_slice_new(VteBgCacheItem);
item->source_type = source_type;
item->source_pixbuf = NULL;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]