[evolution/express2: 3/51] Return a success code when parsing a message



commit 2e5b6ea7a491c1f236aac3a75c3bac5493e890dd
Author: Federico Mena Quintero <federico novell com>
Date:   Tue Mar 16 13:08:33 2010 -0600

    Return a success code when parsing a message
    
    The child functions of parse_message() do not yet return error values, but
    this will make it easier to do something with them in the future if
    they get added.
    
    Signed-off-by: Federico Mena Quintero <federico novell com>

 capplet/settings/mail-guess-servers.c |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)
---
diff --git a/capplet/settings/mail-guess-servers.c b/capplet/settings/mail-guess-servers.c
index bb5f15d..aa5ebd7 100644
--- a/capplet/settings/mail-guess-servers.c
+++ b/capplet/settings/mail-guess-servers.c
@@ -158,7 +158,7 @@ handle_outgoing (xmlNodePtr head, EmailProvider *provider)
 	}
 }
 
-static void
+static gboolean
 parse_message (const char *msg, int length, EmailProvider *provider)
 {
 	xmlDocPtr doc;
@@ -176,7 +176,7 @@ parse_message (const char *msg, int length, EmailProvider *provider)
 
 	if (!node) {
 		g_warning ("Incorrect data: ClientConfig not found ... Quitting\n");
-		return;
+		return FALSE;
 	}
 
 	node = node->children;
@@ -189,7 +189,7 @@ parse_message (const char *msg, int length, EmailProvider *provider)
 
 	if (!node) {
 		g_warning ("Incorrect data: ClientConfig not found ... Quitting\n");
-		return;
+		return FALSE;
 	}
 
 	top = node;
@@ -207,12 +207,14 @@ parse_message (const char *msg, int length, EmailProvider *provider)
 	}
 
 	xmlFreeDoc(doc);
+
+	return TRUE;
 }
 
 static gboolean
 parse_soup_message (SoupMessage *msg, EmailProvider *provider)
 {
-	parse_message (msg->response_body->data, msg->response_body->length, provider);
+	return parse_message (msg->response_body->data, msg->response_body->length, provider);
 }
 
 gboolean



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]