[mutter] Don't trap XErrors in meta_compositor_process_event



commit f77507e8250d5bca16083a863062d579271ff6d4
Author: Adel Gadllah <adel gadllah gmail com>
Date:   Wed Apr 7 13:28:19 2010 +0200

    Don't trap XErrors in meta_compositor_process_event
    
    meta_compositor_process_event uses meta_error_trap_push/pop for
    every event processed by meta_compositor_process_event which isn't needed
    and can cause performance problems.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=613398

 src/compositor/compositor.c |   10 ----------
 1 files changed, 0 insertions(+), 10 deletions(-)
---
diff --git a/src/compositor/compositor.c b/src/compositor/compositor.c
index a84943d..15e170a 100644
--- a/src/compositor/compositor.c
+++ b/src/compositor/compositor.c
@@ -696,14 +696,6 @@ meta_compositor_process_event (MetaCompositor *compositor,
 	}
     }
 
-  /*
-   * This trap is so that none of the compositor functions cause
-   * X errors. This is really a hack, but I'm afraid I don't understand
-   * enough about Metacity/X to know how else you are supposed to do it
-   */
-
-
-  meta_error_trap_push (compositor->display);
   switch (event->type)
     {
     case PropertyNotify:
@@ -726,8 +718,6 @@ meta_compositor_process_event (MetaCompositor *compositor,
       break;
     }
 
-  meta_error_trap_pop (compositor->display, FALSE);
-
   /* Clutter needs to know about MapNotify events otherwise it will
      think the stage is invisible */
   if (event->type == MapNotify)



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]