[gnome-system-tools: 2/3] Fix a few warnings



commit 9934363fd0d65086d34cba0b762f22fb65c436db
Author: Milan Bouchet-Valat <nalimilan club fr>
Date:   Sun Apr 4 16:28:07 2010 +0200

    Fix a few warnings
    
    Very ugly mistakes that seem to be here for a long time, but that didn't have any visible effect.

 src/common/gst-dialog.c         |    2 +-
 src/network/network-locations.c |    5 +----
 src/network/network-locations.h |    2 +-
 3 files changed, 3 insertions(+), 6 deletions(-)
---
diff --git a/src/common/gst-dialog.c b/src/common/gst-dialog.c
index d7435d7..a9d00ca 100644
--- a/src/common/gst-dialog.c
+++ b/src/common/gst-dialog.c
@@ -468,7 +468,7 @@ gst_dialog_get_freeze_level (GstDialog *dialog)
 {
 	GstDialogPrivate *priv;
 
-	g_return_if_fail (GST_IS_DIALOG (dialog));
+	g_return_val_if_fail (GST_IS_DIALOG (dialog), 0);
 
 	priv = GST_DIALOG_GET_PRIVATE (dialog);
 	return priv->frozen;
diff --git a/src/network/network-locations.c b/src/network/network-locations.c
index a859a88..8ccb9bc 100644
--- a/src/network/network-locations.c
+++ b/src/network/network-locations.c
@@ -1131,13 +1131,12 @@ gst_network_locations_save_current (GstNetworkLocations *locations,
   return result;
 }
 
-gboolean
+void
 gst_network_locations_delete_location (GstNetworkLocations *locations,
 				       const gchar         *name)
 {
   GstNetworkLocationsPrivate *priv;
   gchar *filename, *str, *location_path;
-  gboolean success;
 
   g_return_val_if_fail (GST_IS_NETWORK_LOCATIONS (locations), FALSE);
 
@@ -1150,6 +1149,4 @@ gst_network_locations_delete_location (GstNetworkLocations *locations,
   g_unlink (location_path);
   g_free (location_path);
   g_free (filename);
-
-  return success;
 }
diff --git a/src/network/network-locations.h b/src/network/network-locations.h
index f0fb49d..c6b5f79 100644
--- a/src/network/network-locations.h
+++ b/src/network/network-locations.h
@@ -62,7 +62,7 @@ gboolean               gst_network_locations_set_location    (GstNetworkLocation
 							      const gchar         *name);
 gboolean               gst_network_locations_save_current    (GstNetworkLocations *locations,
 							      const gchar         *name);
-gboolean               gst_network_locations_delete_location (GstNetworkLocations *locations,
+void                   gst_network_locations_delete_location (GstNetworkLocations *locations,
 							      const gchar         *name);
 
 G_END_DECLS



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]