[gtk+/native-layout] Reset effective_attrs when necessary
- From: Tristan Van Berkom <tvb src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gtk+/native-layout] Reset effective_attrs when necessary
- Date: Sun, 4 Apr 2010 02:19:17 +0000 (UTC)
commit b5061249e775f930f2fc21fad5b3c0bd29870a45
Author: Matthias Clasen <mclasen redhat com>
Date: Sun Jan 17 23:33:19 2010 -0500
Reset effective_attrs when necessary
This fixes both bug 607217 and bug 607269.
gtk/gtklabel.c | 24 +++++++++++-------------
1 files changed, 11 insertions(+), 13 deletions(-)
---
diff --git a/gtk/gtklabel.c b/gtk/gtklabel.c
index aebd8c6..854318c 100644
--- a/gtk/gtklabel.c
+++ b/gtk/gtklabel.c
@@ -1911,24 +1911,22 @@ gtk_label_recalculate (GtkLabel *label)
guint keyval = label->mnemonic_keyval;
if (label->use_markup)
- {
- gtk_label_set_markup_internal (label, label->label, label->use_underline);
- gtk_label_compose_effective_attrs (label);
- }
+ gtk_label_set_markup_internal (label, label->label, label->use_underline);
else
{
if (label->use_underline)
- {
- gtk_label_set_uline_text_internal (label, label->label);
- gtk_label_compose_effective_attrs (label);
- }
+ gtk_label_set_uline_text_internal (label, label->label);
else
- {
- gtk_label_set_text_internal (label, g_strdup (label->label));
- gtk_label_compose_effective_attrs (label);
- }
+ {
+ if (label->effective_attrs)
+ pango_attr_list_unref (label->effective_attrs);
+ label->effective_attrs = NULL;
+ gtk_label_set_text_internal (label, g_strdup (label->label));
+ }
}
+ gtk_label_compose_effective_attrs (label);
+
if (!label->use_underline)
label->mnemonic_keyval = GDK_VoidSymbol;
@@ -1995,7 +1993,7 @@ gtk_label_set_attributes (GtkLabel *label,
gtk_label_recalculate (label);
- gtk_label_clear_layout (label);
+ gtk_label_clear_layout (label);
gtk_widget_queue_resize (GTK_WIDGET (label));
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]