[gtk+/native-layout] Plug leaks in quartz implementation of gtk_drag_begin_idle()
- From: Tristan Van Berkom <tvb src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gtk+/native-layout] Plug leaks in quartz implementation of gtk_drag_begin_idle()
- Date: Sun, 4 Apr 2010 02:13:44 +0000 (UTC)
commit 51f9ce390fe785aa83aeb3c4f103b7f776b72ea3
Author: Kristian Rietveld <kris gtk org>
Date: Fri Jan 1 20:54:27 2010 +0100
Plug leaks in quartz implementation of gtk_drag_begin_idle()
gtk/gtkdnd-quartz.c | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)
---
diff --git a/gtk/gtkdnd-quartz.c b/gtk/gtkdnd-quartz.c
index dfce31b..e00ef20 100644
--- a/gtk/gtkdnd-quartz.c
+++ b/gtk/gtkdnd-quartz.c
@@ -1073,6 +1073,7 @@ gtk_drag_begin_idle (gpointer arg)
GtkDragSourceOwner *owner;
NSPoint point;
NSSet *types;
+ NSImage *drag_image;
g_assert (info != NULL);
@@ -1083,6 +1084,7 @@ gtk_drag_begin_idle (gpointer arg)
[pasteboard declareTypes:[types allObjects] owner:owner];
+ [owner release];
[types release];
if ((nswindow = get_toplevel_nswindow (info->source_widget)) == NULL)
@@ -1094,7 +1096,9 @@ gtk_drag_begin_idle (gpointer arg)
/* FIXME: If the event isn't a mouse event, use the global cursor position instead */
point = [info->nsevent locationInWindow];
- [nswindow dragImage:_gtk_quartz_create_image_from_pixbuf (info->icon_pixbuf)
+ drag_image = _gtk_quartz_create_image_from_pixbuf (info->icon_pixbuf);
+
+ [nswindow dragImage:drag_image
at:point
offset:NSMakeSize(0, 0)
event:info->nsevent
@@ -1103,6 +1107,7 @@ gtk_drag_begin_idle (gpointer arg)
slideBack:YES];
[info->nsevent release];
+ [drag_image release];
[pool release];
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]