[gnome-shell] Fix fullscreen behaviour
- From: Adel Gadllah <agadllah src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell] Fix fullscreen behaviour
- Date: Thu, 1 Apr 2010 14:53:25 +0000 (UTC)
commit f262473a3f6dc6f40f732dac870269932435e6e1
Author: Adel Gadllah <adel gadllah gmail com>
Date: Wed Mar 31 22:59:20 2010 +0200
Fix fullscreen behaviour
The check in _windowsRestacked checks for
windows[i].x >= primary.x
and
windows[i].x <= primary.x + primary.width
(likewise for y).
This is wrong because a fullscreen window on the secondary screen is likely
to have windows[i].x == primary.x + primary.width which means that the checks
for _both_ screens would be valid, but the first one would win due to
the "break;" statement.
But here the window isn't really on the primary but on the secondary one.
Fix that by using < instead of <= for those checks.
https://bugzilla.gnome.org/show_bug.cgi?id=614509
js/ui/chrome.js | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/js/ui/chrome.js b/js/ui/chrome.js
index 50e0e79..b87c309 100644
--- a/js/ui/chrome.js
+++ b/js/ui/chrome.js
@@ -209,8 +209,8 @@ Chrome.prototype = {
for (let i = windows.length - 1; i > -1; i--) {
let layer = windows[i].get_meta_window().get_layer();
if (layer == Meta.StackLayer.FULLSCREEN) {
- if (windows[i].x >= primary.x && windows[i].x <= primary.x + primary.width &&
- windows[i].y >= primary.y && windows[i].y <= primary.y + primary.height) {
+ if (windows[i].x >= primary.x && windows[i].x < primary.x + primary.width &&
+ windows[i].y >= primary.y && windows[i].y < primary.y + primary.height) {
this._obscuredByFullscreen = true;
break;
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]