[gtk+/xi2: 926/1239] GdkDeviceManagerXI2: Fix valgrind warning.



commit d958d9ce3a61f6a6bafe3ae69f4ca396570e3417
Author: Carlos Garnacho <carlos lanedo com>
Date:   Sat Aug 29 17:14:52 2009 +0200

    GdkDeviceManagerXI2: Fix valgrind warning.
    
    XIEvents seem to provide uninitialized send_event values, according to Valgrind.
    the send_event value of the cookie event is used instead, It looks like it's
    not possible to pass XIEvents to XSendEvent anyway.

 gdk/x11/gdkdevicemanager-xi2.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
---
diff --git a/gdk/x11/gdkdevicemanager-xi2.c b/gdk/x11/gdkdevicemanager-xi2.c
index 13d072a..b3fe903 100644
--- a/gdk/x11/gdkdevicemanager-xi2.c
+++ b/gdk/x11/gdkdevicemanager-xi2.c
@@ -1040,7 +1040,8 @@ gdk_device_manager_xi2_translate_event (GdkEventTranslator *translator,
       break;
     }
 
-  event->any.send_event = ev->send_event;
+  /* FIXME: should use ev->send_event? looks uninitialized sometimes */
+  event->any.send_event = cookie->send_event;
 
   if (return_val)
     {



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]