[gimp] app: Don't blindly increment last-tip-shown



commit 05eb29b7668b1c2e00950c2a27ee26b10ba45815
Author: Martin Nordholts <martinn src gnome org>
Date:   Thu Sep 17 00:20:39 2009 +0200

    app: Don't blindly increment last-tip-shown
    
    Don't blindly increment last-tip-shown so that the sessionrc is not
    modified between each GIMP run. The change is to make it easier to
    write regression tests for sessionrc. Eventually we might want some
    proper fix.

 app/gui/session.c |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)
---
diff --git a/app/gui/session.c b/app/gui/session.c
index ebc27f4..181ff06 100644
--- a/app/gui/session.c
+++ b/app/gui/session.c
@@ -272,10 +272,14 @@ session_save (Gimp     *gimp,
   gimp_dialog_factories_session_save (writer);
   gimp_config_writer_linefeed (writer);
 
-  /* save last tip shown */
+  /* save last tip shown
+   *
+   * FIXME: Make last-tip-shown increment only when used within the
+   * session
+   */
   gimp_config_writer_open (writer, "last-tip-shown");
   gimp_config_writer_printf (writer, "%d",
-                             GIMP_GUI_CONFIG (gimp->config)->last_tip + 1);
+                             GIMP_GUI_CONFIG (gimp->config)->last_tip);
   gimp_config_writer_close (writer);
 
   if (! gimp_config_writer_finish (writer, "end of sessionrc", &error))



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]