[tracker] Fixes: NB#138860, tracker-miner-fs stops crawling if a directory...



commit e888903bf696c6eb06d11660f091c77913a57980
Author: Martyn Russell <martyn lanedo com>
Date:   Mon Sep 14 15:24:49 2009 +0100

    Fixes: NB#138860, tracker-miner-fs stops crawling if a directory...
    
    This was caused by returning TRUE to silently handle missing
    directories, the problem is, we then depend on a "finished" signal
    from the crawler which we never get. As such, we now return FALSE in
    the _start() function if we don't expect to progress any further.
    
    Also, we now don't reset the GCancellable and don't set the crawler
    into state "running" until the initial checks are done first.

 src/libtracker-miner/tracker-crawler.c |   14 +++++---------
 1 files changed, 5 insertions(+), 9 deletions(-)
---
diff --git a/src/libtracker-miner/tracker-crawler.c b/src/libtracker-miner/tracker-crawler.c
index 407d77b..c4a25a8 100644
--- a/src/libtracker-miner/tracker-crawler.c
+++ b/src/libtracker-miner/tracker-crawler.c
@@ -664,20 +664,16 @@ tracker_crawler_start (TrackerCrawler *crawler,
 
 	priv = crawler->private;
 
-	priv->was_started = TRUE;
-	priv->recurse = recurse;
+	if (!g_file_query_exists (file, NULL)) {
+		return FALSE;
+	}
 
 	if (g_cancellable_is_cancelled (priv->cancellable)) {
 		g_cancellable_reset (priv->cancellable);
 	}
 
-	if (!g_file_query_exists (file, NULL)) {
-		/* We return TRUE because this is likely a config
-		 * option and we only return FALSE when we expect to
-		 * not fail.
-		 */
-		return TRUE;
-	}
+	priv->was_started = TRUE;
+	priv->recurse = recurse;
 
 	/* Time the event */
 	if (priv->timer) {



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]