[gtk+/filesystemmodel] When updating a file, handle the case where the old file info is the same as the new one



commit 79101f3588796c564aeefe1493369126c26e2aef
Author: Federico Mena Quintero <federico novell com>
Date:   Wed Sep 2 15:23:21 2009 -0500

    When updating a file, handle the case where the old file info is the same as the new one
    
    This prevents us from inadvertently losing the last ref to the info.
    
    Signed-off-by: Federico Mena Quintero <federico novell com>

 gtk/gtkfilesystemmodel.c |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)
---
diff --git a/gtk/gtkfilesystemmodel.c b/gtk/gtkfilesystemmodel.c
index 1f830f0..0baad5e 100644
--- a/gtk/gtkfilesystemmodel.c
+++ b/gtk/gtkfilesystemmodel.c
@@ -1640,6 +1640,7 @@ _gtk_file_system_model_update_file (GtkFileSystemModel *model,
 {
   FileModelNode *node;
   guint i, id;
+  GFileInfo *old_info;
 
   g_return_if_fail (GTK_IS_FILE_SYSTEM_MODEL (model));
   g_return_if_fail (G_IS_FILE (file));
@@ -1650,9 +1651,12 @@ _gtk_file_system_model_update_file (GtkFileSystemModel *model,
     add_file (model, file, info);
 
   node = get_node (model, id);
-  if (node->info)
-    g_object_unref (node->info);
+
+  old_info = node->info;
   node->info = g_object_ref (info);
+  if (old_info)
+    g_object_unref (old_info);
+
   for (i = 0; i < model->n_columns; i++)
     {
       if (G_VALUE_TYPE (&node->values[i]))



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]