[totem] Bug 593676 - does not display artist on the title bar

[Bastien Nocera <hadess src gnome org>]

commit 71eacd3b43b1f256fe6e2277f34de9f0cc6ca6d1
Author: Bastien Nocera <hadess hadess net>
Date:   Wed Sep 2 17:15:14 2009 +0100

    Bug 593676 - does not display artist on the title bar
    
    Remove the title vs. metadata UI updates distinction. There
    won't be many cases where it's important.

 src/backend/bacon-video-widget-gst-0.10.c |   29 +----------------------------
 src/totem-object.c                        |   14 --------------
 2 files changed, 1 insertions(+), 42 deletions(-)
---
diff --git a/src/backend/bacon-video-widget-gst-0.10.c b/src/backend/bacon-video-widget-gst-0.10.c
index 546c529..d1555ca 100644
--- a/src/backend/bacon-video-widget-gst-0.10.c
+++ b/src/backend/bacon-video-widget-gst-0.10.c
@@ -101,7 +101,6 @@ enum
   SIGNAL_ERROR,
   SIGNAL_EOS,
   SIGNAL_REDIRECT,
-  SIGNAL_TITLE_CHANGE,
   SIGNAL_CHANNELS_CHANGE,
   SIGNAL_TICK,
   SIGNAL_GOT_METADATA,
@@ -1125,21 +1124,6 @@ bacon_video_widget_class_init (BaconVideoWidgetClass * klass)
                   G_TYPE_NONE, 1, G_TYPE_STRING);
 
   /**
-   * BaconVideoWidget::title-change:
-   * @title: the new stream title
-   *
-   * Emitted when the stream's title changes, along with BaconVideoWidget::got-metadata.
-   **/
-  bvw_signals[SIGNAL_TITLE_CHANGE] =
-    g_signal_new ("title-change",
-                  G_TYPE_FROM_CLASS (object_class),
-                  G_SIGNAL_RUN_LAST,
-                  G_STRUCT_OFFSET (BaconVideoWidgetClass, title_change),
-                  NULL, NULL,
-                  g_cclosure_marshal_VOID__STRING,
-                  G_TYPE_NONE, 1, G_TYPE_STRING);
-
-  /**
    * BaconVideoWidget::channels-change:
    *
    * Emitted when the number of audio languages available changes, or when the
@@ -1661,19 +1645,8 @@ bvw_update_tags (BaconVideoWidget * bvw, GstTagList *tag_list, const gchar *type
   /* if we're not interactive, we want to announce metadata
    * only later when we can be sure we got it all */
   if (bvw->priv->use_type == BVW_USE_TYPE_VIDEO ||
-      bvw->priv->use_type == BVW_USE_TYPE_AUDIO) {
-      /* If we updated metadata and we have a new title, send it
-       * using TITLE_CHANGE, so that the UI knows it has a new
-       * streaming title */
-    GValue value = { 0, };
-    
+      bvw->priv->use_type == BVW_USE_TYPE_AUDIO)
     g_signal_emit (bvw, bvw_signals[SIGNAL_GOT_METADATA], 0);
-
-    bacon_video_widget_get_metadata (bvw, BVW_INFO_TITLE, &value);
-    if (g_value_get_string (&value))
-      g_signal_emit (bvw, bvw_signals[SIGNAL_TITLE_CHANGE], 0, g_value_get_string (&value));
-    g_value_unset (&value);
-  }
 }
 
 typedef struct {
diff --git a/src/totem-object.c b/src/totem-object.c
index c79f97a..1eabec7 100644
--- a/src/totem-object.c
+++ b/src/totem-object.c
@@ -2371,16 +2371,6 @@ on_got_redirect (BaconVideoWidget *bvw, const char *mrl, Totem *totem)
 	g_free (new_mrl);
 }
 
-/* This is only called when we are playing a DVD or a radio */
-static void
-on_title_change_event (BaconVideoWidget *bvw, const char *string, Totem *totem)
-{
-	update_mrl_label (totem, string);
-	update_buttons (totem);
-	totem_playlist_set_title (TOTEM_PLAYLIST (totem->playlist),
-				  string, TRUE);
-}
-
 static void
 on_channels_change_event (BaconVideoWidget *bvw, Totem *totem)
 {
@@ -4077,10 +4067,6 @@ video_widget_create (Totem *totem)
 			G_CALLBACK (on_got_redirect),
 			totem);
 	g_signal_connect (G_OBJECT(totem->bvw),
-			"title-change",
-			G_CALLBACK (on_title_change_event),
-			totem);
-	g_signal_connect (G_OBJECT(totem->bvw),
 			"channels-change",
 			G_CALLBACK (on_channels_change_event),
 			totem);