[vala] Warn if signal hides member in base class



commit 38f51d81d939dfd98099109ffd75c9000bee513a
Author: Jürg Billeter <j bitron ch>
Date:   Thu Oct 15 21:27:08 2009 +0200

    Warn if signal hides member in base class

 vala/valasignal.vala |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
---
diff --git a/vala/valasignal.vala b/vala/valasignal.vala
index c58e160..207d8f7 100644
--- a/vala/valasignal.vala
+++ b/vala/valasignal.vala
@@ -265,6 +265,12 @@ public class Vala.Signal : Member, Lockable {
 			cl.add_hidden_method (default_handler);
 			default_handler.check (analyzer);
 		}
+
+
+		if (!external_package && !hides && get_hidden_member () != null) {
+			Report.warning (source_reference, "%s hides inherited signal `%s'. Use the `new' keyword if hiding was intentional".printf (get_full_name (), get_hidden_member ().get_full_name ()));
+		}
+
 		return !error;
 	}
 }



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]